Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 379
    • Issues 379
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1010

Fix #348, #474, #557, #740, #928: improved deduplication logic to prevent skipped uploads

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Agate requested to merge 928-track-mbid-uniqueness into develop Jan 29, 2020
  • Overview 1
  • Commits 2
  • Pipelines 3
  • Changes 6

Improved deduplication logic to prevent skipped files during import

Closes #348 (closed), #474 (closed), #557 (closed), #740 (closed), #928 (closed)

Some of these bugs are duplicates, but the core issues where:

  • Considering a TRACK_ID (Track.mbid in Funkwhale) was unique, for instance leading to orphaned/skipped uploads depending on the processing order. Solved by doing the unicity check with the ALBUM_ID and TRACK_ID combination
  • Not including the disc number when trying to deduplicate tracks, leading to skipped uploads when a track with the same title was present at the same position but in a separate disc

I'm still testing this locally with real-world data, hence the wip.

Edited Jan 29, 2020 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 928-track-mbid-uniqueness