Same track in multiple albums

When I use Picard to tag my albums and a track is present in another album already uploaded the import is not done. Funkwhale skip the import of the track. I guess it detects the track ID and since it is already present in another album, it doesn't matter.

If I delete in picard the tag: Recording Id MusicBrainz I can upload it without that skip.

Hm, I'm not sure what the ideal behaviour should be in that case :/

mentioned in issue #474 (closed)

I ran into this issue as well while investigating why I had ~150 songs that kept being read by the importer but somehow not ending up in the database.

It seems that the assumption that a track has a unique musicbrainz recording ID is wrong. See for instance this recording that appears multiple times in multiple albums: https://musicbrainz.org/recording/df56fa49-de03-4157-8f60-343b70f48df8

I went grepping through the code, and it looks like the only places doing a lookup in the model by mbid is actually the import code? If so, it would be quite straight forward to just change the mbid field to remove the unique constraint in the database, and augment the import code to do a few more checks when looking tracks up by mbid.

Is there any reason that wouldn't work?

mentioned in issue #557 (closed)

Here is an exemple of album where I had problem to import, a triple discs album for instance. https://www.discogs.com/Daniel-B%C3%A9langer-Tricycle/release/3606637 Some tracks (1-8 & 2-11, 1-04 & 2-02, 2-05 & 3-05, 2-09 & 3-08) are considered as same track on same album.

I found out about this issue as well, when investigating why some of my (in-place) imported albums are missing few tracks. For example I have these two albums from same artist:

1. https://musicbrainz.org/release/6ac07f3e-6333-4b41-b1be-d313986256d1?tport=8000
2. https://musicbrainz.org/release/1d1ae5db-af37-4b4f-8f25-e11458d99f00?tport=8000

Both of them overlap in couple of tracks, for example "The Closest Thing to Crazy", so these tracks has same MUSICBRAINZ_TRACKID tag provided by MB Picard tagger. I think tagging is correct (same track=same ID but different album) and I want to hear all the tracks if I decide to play either of these two albums in Funkwhale :)

changed milestone to %0.19.1

changed milestone to %backlog

Just adding snippet of related chat (funkwhale-troubleshooting) history:

• sporiff: I wonder if it would be possible to take both the release id and recording id into account when importing/uploading music
• Jiří Nováček: that sounds like correct approach to me, if that is possible to do...
• cannabiscannibal: Or at the very least, allow an extra variable in the import command to say if you want the current way or that way. Variable options = happy users all around ;)
• Eliot Berriot (he/him): the main blocking point is that we consider a musicbrainz ID to be unique on the Track model, so we should investigate potential breaking changes if we remove this constraint

added TypeBug label

Probably related to https://governance.funkwhale.audio/d/rwny9eJv/prevent-funkwhale-from-skipping-import-of-similar-songs

mentioned in issue #956

changed milestone to %0.21

mentioned in issue #1009 (closed)

Just adding another situation - this issue also comes up when importing albums that are different versions of eachother - i.e., Japanese release of albums vs the American release vs special editions (like Target or iTunes exclusive releases).

As mentioned above, if the unique constraint could (optionally?) be a combination of the track ID and the release ID, I think that would take care of the problem, allowing multiple releases / albums to contain the same track.

As mentioned above, if the unique constraint could (optionally?) be a combination of the track ID and the release ID, I think that would take care of the problem, allowing multiple releases / albums to contain the same track.

I think we'll go this way, I have to test how it affects existing stuff that may rely on the current unique constraint, but it should be mostly fine :)

looking forward for the fix. I have lots of albums with lost tracks because they are part of others...

@Dual-O the fix has been submitted but not released yet. You can try use the development branch if you want to benefit from it now :)

@eliotberriot does this resolved the multiple versions of the same album issue as well? #1009 (closed)

I think it should but I'm not 100% sure

mentioned in commit 64e8c1e4

mentioned in merge request !1010 (merged)

assigned to @eliotberriot

mentioned in commit 61cf04b3

closed via commit 98e1873a

closed via commit 61cf04b3

closed via merge request !1010 (merged)

mentioned in commit 98e1873a

mentioned in commit 09f185ae