Skip to content

Extend merge request !310

Hugh Daschbach requested to merge hdasch/funkwhale-android:bottom-sheet-refinement into develop

This changeset consists of 20 commits.

The first seven address issues discussed in merge request !310 (closed). These issues improve the UI changes for the NowPlayingBottomSheet. These changes are:

  • 781152d - Suppress BottomSheet close on show.
  • b2701a2 - Prevent BottomSheet tap leaking to nav panels.
  • 4c1ba72 - Give notification tap action semantic meaning.
  • d4f5fe1 - Show BottomSheet upon notification tap.
  • f50c513 - Increase player controls touchpoint size.
  • 08df4d4 - Persist BottomSheet open/close state.
  • c1e4e89 - Remove redundant LinearLayout.

The next three commits fix crashes when switching between portrait and landscape views. The concern for these crashes were raised in this comment from !310 (closed). The crashes are further described in issue #145 (closed). These changes are:

  • 752542f - Do not create unnecessary Picasso objects.
  • 2708f67 - Refactor CoverArt.withContext().
  • 4ca60be - Fix landscape view induced MainActivity leak.

The final ten commits clean up warnings reported by AndroidStudio. These are not stability or usability issues, but most stem from changes made in !310 (closed) and this merge request. These changes are:

  • ba5574d - Cleanup: remove unused imports.
  • fabd78d - Cleanup: remove unused function.
  • 8d69fcc - Cleanup: mark internal fields private.
  • 3bbdd3f - Cleanup: minor tweaks suggested by AndroidStudio.
  • 1b19762 - Cleanup: do not create unused field.
  • 09b6a27 - Cleanup: Avoid shadowing "it" object.
  • 8890e3c - Cleanup: "cascading if" -> "when".
  • b263aa7 - Cleanup: use ContextCompat to load drawables.
  • d949f9f - Cleanup: SuppressLint adjustments.
  • 96edf76 - hdasch/bottom-sheet-refinement Add a changelog entry.

With these changes, I believe !310 (closed) deserves review and further testing. It should be considered a merge candidate.

Merge request reports