Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Funkwhale Android Funkwhale Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 62
    • Issues 62
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • Funkwhale AndroidFunkwhale Android
  • Merge requests
  • !310

Improve player bottom sheet, in particular fling support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Christophe Henry requested to merge christophehenry/funkwhale-android:improve-player-bottom-sheet-motion-layout into develop Feb 02, 2023
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 25

Fixes #101 #141

The current bottom sheet have usability problems. In particular, support of fling gesture is atrocious. This is an attempt to improve the situation using standard Google's Material BottomSheetBehavior. It also converts most of the layout to ConstraintLayout to lighten it up and uses databinding + ViewModel that is less error-prone than manually updating the views.

It also enables ladscape mode in AndroidManifest.xml because, weirdly some layouts for landscape did exists but the app was forced to portrait.

(Sorry for the size of the MR. It seems I'm unable to keep them them small 😅)

Edited Feb 02, 2023 by Christophe Henry
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improve-player-bottom-sheet-motion-layout