Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 380
    • Issues 380
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !935

S3 proxy fails on nginx

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Agate requested to merge s3-proxy-fails-on-nginx into master Oct 16, 2019
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 3

Tested with Dag Stenstad on Matrix.

Basically, nginx didn't catch the whole URL when proxying the request to the S3 storage, because we didn't escaped the S3 signature that is included in query parameters.

cc @funkwhale/reviewers-python

Edited Oct 17, 2019 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: s3-proxy-fails-on-nginx