S3 proxy fails on nginx (!935) · Merge requests · funkwhale / funkwhale · GitLab

Snippets Groups Projects

Merged Agate requested to merge s3-proxy-fails-on-nginx into master 5 years ago

All threads resolved!

Tested with Dag Stenstad on Matrix.

Basically, nginx didn't catch the whole URL when proxying the request to the S3 storage, because we didn't escaped the S3 signature that is included in query parameters.

cc @funkwhale/reviewers-python

Edited 5 years ago by Agate

Activity

Agate changed milestone to %0.20.1 5 years ago

changed milestone to %0.20.1
Agate added AreaBackend AreaDeployment TypeBug labels 5 years ago

added AreaBackend AreaDeployment TypeBug labels
Agate changed the description 5 years ago

changed the description
Agate changed target branch from develop to master 5 years ago

changed target branch from develop to master
Agate marked as a Work In Progress 5 years ago

marked as a Work In Progress
Esteban @emanchado started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Agate
Last reply by Agate 5 years ago

Agate added 1 commit 5 years ago

added 1 commit

4a5484c7 - Fix audio serving issues under S3/nginx when signatures are enabled

Compare with previous version

Agate resolved all threads 5 years ago

resolved all threads

Agate unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress

Agate mentioned in commit 5 years ago

mentioned in commit 109c4906

Agate merged 5 years ago

merged

Please register or sign in to reply