Skip to content
Snippets Groups Projects

Fix docker development set-up (#2102)

Merged Marcos Peña requested to merge 2102-fix-development-docker-setup into develop

Closes #2102 (closed)

I'll explain the fixes since it affects multiple files:

  • api/Dockerfile: py3-cryptography-38.0.3-r0 breaks world[py3-cryptography=38.0.3-r0], so I've simply updated it to r1.
  • api/Dockerfile: dev-requirements.txt dependencies were not loaded because of an invisible leading character in ln 74-80 (I almost went nuts with this one). So libraries for dev weren't loaded (/bin/sh:   grep: not found), hence the modules not found exceptions for factory and debug_toolbar.
  • docker/nginx/conf.dev: restored location /statifiles block. Otherwise static files wont' load in admin pages
  • Finally api/funkwhale_api/music/fake_data.py: since the tracks created weren't playable they weren't displayed. create_data method it's not called anywhere in the codebase. Apparently it's only used when setting up local data.

Merge request reports

Merge request pipeline #29017 passed with warnings

Merge request pipeline passed with warnings for afe534db

Test coverage 83.00% (0.00%) from 4 jobs
Approval is optional

Merged by MargeMarge 1 year ago (Mar 20, 2023 11:43am UTC)

Merge details

Pipeline #29019 failed

Pipeline failed for afe534db on develop

Test coverage 83.00% (0.00%) from 4 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading