Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 396
    • Issues 396
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1863

New task checking if remote instance is reachable to avoid playback latence

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open petitminion requested to merge petitminion/funkwhale-petitminion:1711-ping_remote into develop Jun 30, 2022
  • Overview 3
  • Commits 4
  • Pipelines 8
  • Changes 7

Closes #1813

This allow to skip tracks that are not playable on the queue. It increase playback continuity.

Radios can have a little latency before skipping tracks from the queryset (like a minute or so)

Some of the migrations are related to a django update since they appears on develop.

  • settings.MUSIC_USE_DENORMALIZATION: in track model
  • Add a test to check if we can reach some outsite server ? (which server to use ? google ? ^^ ) Because if the task is trigerred when there is a local network error, all content will be set as unplayable during one hour.. Or we could trigger this task again when a request is made to library and no result is returned ?
  • Create a bug where some track will throw 404 on uploads ? This seems to be an issue present in develop for specifics tracks. I keep this here as a reminder or if someone wants to check.
Edited Jul 11, 2022 by petitminion
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 1711-ping_remote