Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 395
    • Issues 395
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1241

Support AIFF file format

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philipp Wolfer requested to merge phw/funkwhale:aiff-format-support into develop Nov 21, 2020
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 6

Related issue: #1243 (closed)

This Merge Request includes:

  • Tests
  • A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)

This ads support for the AIFF file format, tagged with ID3 tags. Tested locally, including playback.

Some implementation notes:

  • A test for the artists tag is commented out. There is actually a bug in FW for reading this properly. The tag is supposed to contain a proper multi-value tag (in ID3 a TXXX with actually multiple distinct values), but FW currently only seems to use the first value. This is also broken in the MP3 test, there is just seems to kind of work because the test.mp3 actually contains only a single value "Binärpilot; Another artist". I haven't looked into the details of this issue yet, but it is otherwise unrelated to AIFF support.
  • Support for WAVE files would look very similar, just that for WAVE we should also consider RIFF INFO tags (in addition to ID3, preferring ID3 if possible). Mutagen currently does not directly support RIFF INFO, but it can be implemented on top of what mutagen provides. Picard does something like this, see https://github.com/metabrainz/picard/blob/master/picard/formats/wav.py#L45 . Not yet sure how this would fit into the metadata model FW uses.

Funkwhale is really great, enjoying it very much. Awesome work. And, in comparison to it's complexity, relatively easy to hack on :D

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: aiff-format-support