Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 407
    • Issues 407
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1177

Album pagination

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge album-pagination into develop Jul 24, 2020
  • Overview 1
  • Commits 6
  • Pipelines 2
  • Changes 9

Closes #1136 (closed)

Following feedback in #1136 (closed), as well as an interesting edge-case on my pod, I've found some issues with lots of content being rendered on a page at once for albums and channels. In the edge-case I have on my server, there is an album with 155 tracks on it, but the page caps out rendering at 50 despite 100 being fetched in the call.

image

In addition to this as noted in the above issue, channels are difficult to navigate once too many items are added, and especially when a user simply wants to view and add items from the beginning of the series (the user has to keep clicking "Show more" to append more objects and then hit the play button to replace their queue or go to the page to add it).

image

There is also an issue to be resolved with the play button on channel series as they are not recognised as playable

image

This MR proposes the following changes:

  • The addition of pagination to the album and channel pages as well as a limit on how much is loaded in the initial page load
  • The re-introduction of play actions in the entry/track queue
  • A reworking of the podcasts page so that the Overview tab shows the latest episodes in descending order, while the "All Episodes" shows the episodes chronologically from the start
  • Fix an issue with series not being playable from the album card

image

image

image

image

Edited Jul 25, 2020 by Ciarán Ainsworth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: album-pagination