Follow-up from "Fix 500 when fetching tracks from Apache+S3 (#1979)"
The following discussion from !2227 (closed) should be addressed:
-
@rickosborne started a discussion: (+1 comment) I can confirm that this patch did work for me, when running against S3. I applied the changes against my instance running 1.2.9 (just this patch, not everything else between 1.2.9 and it), and it worked without a hitch.
I might also suggest that the docs in the
.env
example get a small tweak. Right now, they say:# If you use a S3-compatible storage such as minio, set the following variable # the full URL to the storage server. Example: # AWS_S3_ENDPOINT_URL=https://minio.mydomain.com
The way that's worded, it makes it seem like you only need the line if you're using something compatible with S3, but not actually S3 itself. So maybe "S3 or S3-compatible"? Or, just add an S3 example in addition to the minio one, such as:
# AWS_S3_ENDPOINT_URL=https://s3.us-east-1.amazonaws.com/
That would be good, also, because it shows that you don't need to duplicate the bucket name from
AWS_STORAGE_BUCKET_NAME
.But, obviously, I consider the doc tweak a nice-to-have. As it is, this PR works great!