Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 379
    • Issues 379
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !2227

Fix 500 when fetching tracks from Apache+S3 (#1979)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Rick Osborne requested to merge rickosborne/funkwhale:rickosborne/apache2-s3-500 into develop Nov 26, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 2

This (locally) fixes #1979. Someone with more familiarity should really look at it, though: there's some asymmetry in funkwhale_api/music/views.py between nginx and apache2 which I don't entirely understand, so I'm not sure how safe this is. It also seems like this was an intentional change in 300e24db. But also, the test introduced in that change, test_serve_file_in_place, doesn't work for me locally despite the rest of the tests being green ... so ... 🤷 ?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rickosborne/apache2-s3-500