Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
funkwhale
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
wxcafé
funkwhale
Commits
367014f7
Verified
Commit
367014f7
authored
7 years ago
by
Eliot Berriot
Browse files
Options
Downloads
Patches
Plain Diff
Added owner permission to check user has the right to read/update object
parent
3e277aad
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
api/funkwhale_api/common/permissions.py
+39
-0
39 additions, 0 deletions
api/funkwhale_api/common/permissions.py
api/tests/common/test_permissions.py
+43
-0
43 additions, 0 deletions
api/tests/common/test_permissions.py
with
82 additions
and
0 deletions
api/funkwhale_api/common/permissions.py
+
39
−
0
View file @
367014f7
import
operator
from
django.conf
import
settings
from
django.http
import
Http404
from
rest_framework.permissions
import
BasePermission
,
DjangoModelPermissions
...
...
@@ -20,3 +23,39 @@ class HasModelPermission(DjangoModelPermissions):
"""
def
get_required_permissions
(
self
,
method
,
model_cls
):
return
super
().
get_required_permissions
(
method
,
self
.
model
)
class
OwnerPermission
(
BasePermission
):
"""
Ensure the request user is the owner of the object.
Usage:
class MyView(APIView):
model = MyModel
permission_classes = [OwnerPermission]
owner_field =
'
owner
'
owner_checks = [
'
read
'
,
'
write
'
]
"""
perms_map
=
{
'
GET
'
:
'
read
'
,
'
OPTIONS
'
:
'
read
'
,
'
HEAD
'
:
'
read
'
,
'
POST
'
:
'
write
'
,
'
PUT
'
:
'
write
'
,
'
PATCH
'
:
'
write
'
,
'
DELETE
'
:
'
write
'
,
}
def
has_object_permission
(
self
,
request
,
view
,
obj
):
method_check
=
self
.
perms_map
[
request
.
method
]
owner_checks
=
getattr
(
view
,
'
owner_checks
'
,
[
'
read
'
,
'
write
'
])
if
method_check
not
in
owner_checks
:
# check not enabled
return
True
owner_field
=
getattr
(
view
,
'
owner_field
'
,
'
user
'
)
owner
=
operator
.
attrgetter
(
owner_field
)(
obj
)
if
owner
!=
request
.
user
:
raise
Http404
return
True
This diff is collapsed.
Click to expand it.
api/tests/common/test_permissions.py
0 → 100644
+
43
−
0
View file @
367014f7
import
pytest
from
rest_framework.views
import
APIView
from
django.contrib.auth.models
import
AnonymousUser
from
django.http
import
Http404
from
funkwhale_api.common
import
permissions
def
test_owner_permission_owner_field_ok
(
nodb_factories
,
api_request
):
playlist
=
nodb_factories
[
'
playlists.Playlist
'
]()
view
=
APIView
.
as_view
()
permission
=
permissions
.
OwnerPermission
()
request
=
api_request
.
get
(
'
/
'
)
setattr
(
request
,
'
user
'
,
playlist
.
user
)
check
=
permission
.
has_object_permission
(
request
,
view
,
playlist
)
assert
check
is
True
def
test_owner_permission_owner_field_not_ok
(
nodb_factories
,
api_request
):
playlist
=
nodb_factories
[
'
playlists.Playlist
'
]()
view
=
APIView
.
as_view
()
permission
=
permissions
.
OwnerPermission
()
request
=
api_request
.
get
(
'
/
'
)
setattr
(
request
,
'
user
'
,
AnonymousUser
())
with
pytest
.
raises
(
Http404
):
permission
.
has_object_permission
(
request
,
view
,
playlist
)
def
test_owner_permission_read_only
(
nodb_factories
,
api_request
):
playlist
=
nodb_factories
[
'
playlists.Playlist
'
]()
view
=
APIView
.
as_view
()
setattr
(
view
,
'
owner_checks
'
,
[
'
write
'
])
permission
=
permissions
.
OwnerPermission
()
request
=
api_request
.
get
(
'
/
'
)
setattr
(
request
,
'
user
'
,
AnonymousUser
())
check
=
permission
.
has_object_permission
(
request
,
view
,
playlist
)
assert
check
is
True
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment