Skip to content
Snippets Groups Projects
Verified Commit 0fc455ba authored by Georg Krause's avatar Georg Krause
Browse files

Add hint to Contribution guide to run linting

parent 895420cb
No related branches found
No related tags found
No related merge requests found
...@@ -303,11 +303,13 @@ Typical workflow for a contribution ...@@ -303,11 +303,13 @@ Typical workflow for a contribution
2. If working on an issue, assign yourself to the issue. Otherwise, consider open an issue before starting to work on something, especially for new features. 2. If working on an issue, assign yourself to the issue. Otherwise, consider open an issue before starting to work on something, especially for new features.
3. Create a dedicated branch for your work ``42-awesome-fix``. It is good practice to prefix your branch name with the ID of the issue you are solving. 3. Create a dedicated branch for your work ``42-awesome-fix``. It is good practice to prefix your branch name with the ID of the issue you are solving.
4. Work on your stuff 4. Work on your stuff
5. Commit small, atomic changes to make it easier to review your contribution 5. [Optional] Consider running ``yarn lint`` in ``front`` if you changed something there. Consider fixing some
6. Add a changelog fragment to summarize your changes: ``echo "Implemented awesome stuff (#42)" > changes/changelog.d/42.feature`` linting errors in the files you touched.
7. Push your branch 6. Commit small, atomic changes to make it easier to review your contribution
8. Create your merge request 7. Add a changelog fragment to summarize your changes: ``echo "Implemented awesome stuff (#42)" > changes/changelog.d/42.feature``
9. Take a step back and enjoy, we're really grateful you did all of this and took the time to contribute! 8. Push your branch
9. Create your merge request
10. Take a step back and enjoy, we're really grateful you did all of this and took the time to contribute!
Changelog management Changelog management
-------------------- --------------------
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment