See #248: ensure invitation codes are case insensitive

api/funkwhale_api/manage/serializers.py

@@ -146,7 +146,7 @@ class ManageInvitationSerializer(serializers.ModelSerializer):
     def validate_code(self, value):
         if not value:
             return value
-        if users_models.Invitation.objects.filter(code=value.lower()).exists():
+        if users_models.Invitation.objects.filter(code__iexact=value).exists():
             raise serializers.ValidationError(
                 "An invitation with this code already exists"
             )

api/funkwhale_api/users/models.py

@@ -152,7 +152,7 @@ class User(AbstractUser):
 
 def generate_code(length=10):
     return "".join(
-        random.SystemRandom().choice(string.ascii_lowercase) for _ in range(length)
+        random.SystemRandom().choice(string.ascii_uppercase) for _ in range(length)
     )
 
 

api/funkwhale_api/users/serializers.py

@@ -18,7 +18,7 @@ class RegisterSerializer(RS):
             return
 
         try:
-            return models.Invitation.objects.open().get(code=value.lower())
+            return models.Invitation.objects.open().get(code__iexact=value)
         except models.Invitation.DoesNotExist:
             raise serializers.ValidationError("Invalid invitation code")
 

api/tests/users/test_views.py

@@ -52,7 +52,7 @@ def test_can_disable_registration_view(preferences, api_client, db):
 
 def test_can_signup_with_invitation(preferences, factories, api_client):
     url = reverse("rest_register")
-    invitation = factories["users.Invitation"](code="hello")
+    invitation = factories["users.Invitation"](code="Hello")
     data = {
         "username": "test1",
         "email": "test1@test.com",