Merge branch '422-musicbrainz-button-no-mbid' into 'develop'

Fix #422: Do not display "view on MusicBrainz" button if we miss the mbid

Closes #422

See merge request funkwhale/funkwhale!450

changes/changelog.d/422.bugfix

+Do not display "view on MusicBrainz" button if we miss the mbid (#422)

front/src/components/library/Album.vue

@@ -33,7 +33,7 @@
             <i class="wikipedia icon"></i>
             <translate>Search on Wikipedia</translate>
           </a>
-          <a :href="musicbrainzUrl" target="_blank" class="ui button">
+          <a v-if="musicbrainzUrl" :href="musicbrainzUrl" target="_blank" class="ui button">
             <i class="external icon"></i>
             <translate>View on MusicBrainz</translate>
           </a>
@@ -105,7 +105,9 @@ export default {
       return 'https://en.wikipedia.org/w/index.php?search=' + encodeURI(this.album.title + ' ' + this.album.artist.name)
     },
     musicbrainzUrl () {
-      return 'https://musicbrainz.org/release/' + this.album.mbid
+      if (this.album.mbid) {
+        return 'https://musicbrainz.org/release/' + this.album.mbid
+      }
     },
     headerStyle () {
       if (!this.album.cover.original) {

front/src/components/library/Artist.vue

@@ -31,7 +31,7 @@
             <i class="wikipedia icon"></i>
             <translate>Search on Wikipedia</translate>
           </a>
-          <a :href="musicbrainzUrl" target="_blank" class="ui button">
+          <a v-if="musicbrainzUrl" :href="musicbrainzUrl" target="_blank" class="ui button">
             <i class="external icon"></i>
             <translate>View on MusicBrainz</translate>
           </a>
@@ -154,7 +154,9 @@ export default {
       return 'https://en.wikipedia.org/w/index.php?search=' + encodeURI(this.artist.name)
     },
     musicbrainzUrl () {
-      return 'https://musicbrainz.org/artist/' + this.artist.mbid
+      if (this.artist.mbid) {
+        return 'https://musicbrainz.org/artist/' + this.artist.mbid
+      }
     },
     allTracks () {
       let tracks = []

front/src/components/library/Track.vue

@@ -40,7 +40,7 @@
             <i class="wikipedia icon"></i>
             <translate>Search on Wikipedia</translate>
           </a>
-          <a :href="musicbrainzUrl" target="_blank" class="ui button">
+          <a v-if="musicbrainzUrl" :href="musicbrainzUrl" target="_blank" class="ui button">
             <i class="external icon"></i>
             <translate>View on MusicBrainz</translate>
           </a>
@@ -199,7 +199,9 @@ export default {
       return 'https://en.wikipedia.org/w/index.php?search=' + encodeURI(this.track.title + ' ' + this.track.artist.name)
     },
     musicbrainzUrl () {
-      return 'https://musicbrainz.org/recording/' + this.track.mbid
+      if (this.track.mbid) {
+        return 'https://musicbrainz.org/recording/' + this.track.mbid
+      }
     },
     downloadUrl () {
       let u = this.$store.getters['instance/absoluteUrl'](this.track.listen_url)