Skip to content
Snippets Groups Projects

feat: add alert and modal components

Merged Kasper Seweryn requested to merge wvffle/modal into main

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ciarán Ainsworth
  • Ciarán Ainsworth
  • Ciarán Ainsworth
  • @wvffle I've added some suggestions to make the documentation a bit clearer. From a code/presentation perspective, I think this looks really nice 🎉

    I'll hand over to @mjourdan for the visual review.

  • Kasper Seweryn resolved all threads

    resolved all threads

  • Kasper Seweryn resolved all threads

    resolved all threads

  • Kasper Seweryn resolved all threads

    resolved all threads

  • Kasper Seweryn resolved all threads

    resolved all threads

  • Kasper Seweryn resolved all threads

    resolved all threads

  • Kasper Seweryn added 1 commit

    added 1 commit

    • fd63b3b2 - docs: add section descriptions

    Compare with previous version

  • Ciarán Ainsworth approved this merge request

    approved this merge request

  • Kasper Seweryn added 6 commits

    added 6 commits

    Compare with previous version

  • Kasper Seweryn added 1 commit

    added 1 commit

    • 179678d3 - fix: add missing type import

    Compare with previous version

    • Resolved by Kasper Seweryn

      Visual review:

      • H2 could use some more bottom-padding (26 px rather than 16px)
      • horizontal lines are useful as separators when the modal content is scrollable
      • the close alert button
        • has a too bright background in dark theme
        • should use a dark label in light theme (blue-900 over blue-100 would probably be ok)
      • a close button inside each modal would be welcome, especially with nested modals
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading