feat: add alert and modal components
Merge request reports
Activity
Filter activity
assigned to @wvffle
- Resolved by Kasper Seweryn
- Resolved by Kasper Seweryn
- Resolved by Kasper Seweryn
- Resolved by Kasper Seweryn
- Resolved by Kasper Seweryn
- Resolved by Kasper Seweryn
added 6 commits
-
fd63b3b2...2cba5b74 - 3 commits from branch
main
- 7f53b56b - feat: add alert and modal components
- be424c71 - docs: fix nested modals example
- 9c81d16e - docs: add section descriptions
Toggle commit list-
fd63b3b2...2cba5b74 - 3 commits from branch
- Resolved by Kasper Seweryn
Visual review:
- H2 could use some more bottom-padding (26 px rather than 16px)
- horizontal lines are useful as separators when the modal content is scrollable
- the close alert button
- has a too bright background in dark theme
- should use a dark label in light theme (blue-900 over blue-100 would probably be ok)
- a close button inside each modal would be welcome, especially with nested modals
Please register or sign in to reply