Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 412
    • Issues 412
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 25
    • Merge requests 25
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !840

Enhance artists list by using our new artist card and remove masonry

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Agate requested to merge artist-cards into develop Jul 25, 2019
  • Overview 7
  • Commits 3
  • Pipelines 4
  • Changes 4

I had to work on a simpler artist card widget for the tag feature:

image

When viewing /library/artists, we currently have this card (it's been here for two years I think):

image

I tend to think the first one is less cluttered and leaves more visual space to breath, which is why I suggest we replace the old one with this new design. By removing the listing of albums, it also removes the need for our masonry layout (which is quite buggy and slow at the moment), and allows us to display more artist cards in the same space (50% more in this example, but this is dependant of the number of albums associated with the displayed artists).

cc @funkwhale/reviewers-front

Before

image

After

image

Edited Jul 25, 2019 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: artist-cards