Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 409
    • Issues 409
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !825

Fix #875 Broken embed (develop)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Agate requested to merge broken-embed into develop Jul 10, 2019
  • Overview 2
  • Commits 4
  • Pipelines 3
  • Changes 4

Fix #875 (closed)

  • Update to node 11 in development (needed to update dependencies and reproduce the issue)
  • Ensure embed wizard can work when using a different instance (useful to reproduce the issue and when working on embeding in general, because before you needed to run the API on the same domain)
  • Fix the issue (plyr stylesheet was not explicitely included, and this broke after the 3.5.4 release

cc @funkwhale/reviewers-front (preview at http://funkwhale.pages.funkwhale.audio/-/funkwhale/-/jobs/26005/artifacts/front-review/index.html)

Edited Jul 10, 2019 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: broken-embed