Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 405
    • Issues 405
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !530

Fix #658: Support blind key rotation in HTTP Signatures

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Agate requested to merge 658-blind-key-rotation into develop Jan 11, 2019
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 9

Closes #658 (closed)

Cf https://blog.dereferenced.org/the-case-for-blind-key-rotation

When we fail on an invalid signature while authenticating an HTTP request, we'll now:

  1. Catch the error
  2. Refetch the actor object (to potentially load a new public key)
  3. Retry the signature verification with the new public key (and fail for real this time in case of error)

Todo:

  • Regenerate local actor key when a Delete activity occur
Edited Jan 11, 2019 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 658-blind-key-rotation