Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 405
    • Issues 405
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !2029

Ensure SPA HTML files get loaded with UTF-8 encoding

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Philipp Wolfer requested to merge phw/funkwhale:fix-index.html-encoding into develop Oct 17, 2022
  • Overview 4
  • Commits 1
  • Pipelines 3
  • Changes 2

Fixes issues with wrong encoding of the "Loading Funkwhale…" text in index.html. If loaded via the backend the index.html got read with latin1 encoding, resulting in the ellipsis character being garbled as shown in the screenshot.

grafik

The reason is for how the requests module handles the encoding and tries to read it from the HTTP headers, see https://requests.readthedocs.io/en/latest/user/advanced/#encodings

Explicitly set response.encoding to enforce proper encoding is used for reading.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-index.html-encoding