Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 375
    • Issues 375
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1931

Draft: Replace direct usage of mutagen with mediafile

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open interru requested to merge interru/funkwhale:use_mediafile_for_metatags into develop Jul 29, 2022
  • Overview 8
  • Commits 3
  • Pipelines 0
  • Changes 4

Currently heavily WIP.

Ping: @JuniorJPDJ because you probably know mediafile. 🙂

TODO

  • Need to clean the workarounds/hacks and fixes for mediafile and push to upstream
  • We probably want to adapt the layers between Funkwhale and mediafile. I currently mostly focused on changing Metadata because it was an easy starting point.
  • 9 tests are still failing
Results (33.96s):
     142 passed
       9 failed
         - tests/music/test_metadata.py:295 test_track_metadata_serializer[test.ogg-expected1]
         - tests/music/test_metadata.py:295 test_track_metadata_serializer[test.mp3-expected0]
         - tests/music/test_metadata.py:295 test_track_metadata_serializer[test_theora.ogg-expected3]
         - tests/music/test_metadata.py:295 test_track_metadata_serializer[sample.flac-expected4]
         - tests/music/test_metadata.py:99 test_can_get_metadata_from_ogg_theora_file[musicbrainz_albumid-1f0441ad-e609-446d-b355-809c445773cf]
         - tests/music/test_metadata.py:180 test_can_get_pictures[with_cover.ogg]
         - tests/music/test_metadata.py:510 test_fake_metadata_with_serializer
         - tests/music/test_metadata.py:44 test_can_get_metadata_all
         - tests/music/test_metadata.py:295 test_track_metadata_serializer[test.opus-expected2]

Closes #1671

Further updates probably on Monday.

Edited Jul 29, 2022 by interru
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use_mediafile_for_metatags