Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 378
    • Issues 378
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1450

Resolve 3.2 update warnings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged petitminion requested to merge petitminion/funkwhale-petitminion:1663-3.2-update-django-config into develop Jan 12, 2022
  • Overview 6
  • Commits 3
  • Pipelines 5
  • Changes 10

the on thing I couldn't resolve : federation.serializer still has a reference at NullBooleanField : manuallyApprovesFollowers = serializers.NullBooleanField(required=False). But if I change it to serializers.BooleanField(required=False, null=True) I got an error :

  File "/app/funkwhale_api/federation/serializers.py", line 240, in ActorSerializer
    manuallyApprovesFollowers = serializers.BooleanField(required=False, null=True)
TypeError: __init__() got an unexpected keyword argument 'null'

related to #1663 (closed)

Edited Jan 12, 2022 by petitminion
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1663-3.2-update-django-config