Resolve "Update Channels"

Closes #1514 (closed)

added 1 commit

• 5b06d497 - Update channels

Compare with previous version

As far as I can tell, you likely need to change this: https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/api/config/routing.py#L11 to use the .as_asgi() method call.

You'll also need to update the failing tests to use consumer = consumers.JsonAuthConsumer.as_view()(scope=scope) instead of consumer = consumers.JsonAuthConsumer(scope=scope), as far as I can tell.

Middlewares should be okay since Funkwhale's already under Django 3, so async ready, but I'm not 100% sure.

added 3 commits

• 5b06d497...c29f6778 - 2 commits from branch develop
• c6b9a891 - Update channels

Compare with previous version

added 1 commit

• d42a1d92 - Fix routing according to the changelog

Compare with previous version

added 1 commit

• d12aa5a1 - Fix formatting

Compare with previous version

@agate thanks for the hints, but this doesnt fully solve the issues. Sadly JsonAuthConsumer does not provide an as_view functionality.

I think I'd need to dive into this guide: https://channels.readthedocs.io/en/stable/topics/testing.html

added 1 commit

• 5840e53c - Use suggested way to test django channels since version 3

Compare with previous version

marked this merge request as ready

added 1 commit

• 4cae73b3 - Remove unused import

Compare with previous version

added 1 commit

• ddc2c1bf - Test to increase test case isolation

Compare with previous version

added 2 commits

• 3c749e2d - Test to increase test case isolation
• 8343afea - Remove testcase which cases trouble

Compare with previous version

added 1 commit

• a77b52cb - Remove unused import

Compare with previous version

merged

changed milestone to %1.2.0