Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 399
    • Issues 399
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1313

Profile menu redesign

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge profile-menu-redesign into develop May 09, 2021
  • Overview 18
  • Commits 25
  • Pipelines 26
  • Changes 13

Related to #1235 Closes #1242 (closed)

Currently, user actions are split between the dropdown menu at the top of the screen and the footer. The footer in particular is a problem as it is inaccessible to mobile users without a lot of scrolling, and its behaviour on desktop isn't quite as expected (see #1242 (closed)). This MR looks to remove the footer entirely while migrating its functionality elsewhere.

Screen_Recording_2021-05-01_at_21.30.15

  • Replace footer actions with a dropdown user menu
  • Create a modal menu for mobile users
  • Remove footer
  • Linting
  • Close Modal on mobile if a menu entry is clicked
  • Add instance switcher again
  • Deduplicate themes, we have them in UserModal, UserMenu and Sidebar
  • the currently selected option should appear directly in the modal
Edited Nov 26, 2021 by Ciarán Ainsworth
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: profile-menu-redesign