Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 399
    • Issues 399
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1309

Update track table

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge fix-track-table into develop May 01, 2021
  • Overview 35
  • Commits 29
  • Pipelines 33
  • Changes 34

The track tables are looking a bit strange. The play button is hard to see and doesn't light up very visibly when music is playing. Both the track name and the button currently play the track.

This MR:

  • Removes the table element currently used in track tables and replaces it with a flexible grid
  • Implements new design ideas to improve UX
  • Replaces all existing track tables with a single reusable element
  • Offers a mobile-friendly interaction flow
  • Includes a changelog fragment

Before

image

After

Desktop

Kapture_2021-05-06_at_01.01.58

Mobile

Kapture_2021-05-06_at_00.36.38

Todo

  • Replace channel lists
  • Move play options to mixin to share across components
  • Create right click context menu to show play options at pointer #1579
  • Check accessibility
Edited Sep 21, 2021 by Georg Krause
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-track-table