Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 406
    • Issues 406
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1306

Resolve "Channel: clicking auf "Subscribe" when not logged in still updates the subscriber count"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge 1296-channel-clicking-auf-subscribe-when-not-logged-in-still-updates-the-subscriber-count into develop Apr 30, 2021
  • Overview 0
  • Commits 3
  • Pipelines 4
  • Changes 4

Related issue: #1296 (closed)

This Merge Request includes:

  • A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)

Currently, we have no way of feeding back to the user that they need to log in to perform certain actions. This MR introduces a reusable modal for prompting users to log in or sign up to complete actions.

  • Clicking on login will pass the previous route to redirect users back to where they were before attempting login
  • Signup button will hide if admin has disabled signups
  • Modal can be passed messages and icons from the parent element to allow us to customize it for different situations

Screen_Recording_2021-04-30_at_21.27.09

Edited Apr 30, 2021 by Ciarán Ainsworth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1296-channel-clicking-auf-subscribe-when-not-logged-in-still-updates-the-subscriber-count