Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
funkwhale
funkwhale
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • funkwhale
  • funkwhalefunkwhale
  • Merge Requests
  • !1260

Merged
Opened Jan 03, 2021 by heyarne@heyarneContributor
  • Report abuse
Report abuse

Small Player / Queue Improvements

  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 2

While technically these are two unrelated changes I felt like they were small enough to group them together in one merge request:

  1. There currently is an underlined whitespace before the album name in the player and the queue which is removed by c2587e0a
  2. I found it to be quite confusing at first to find out how to close the queue. The ESC button is meaningful enough to just try it out, but this commit adds an explicit button (which is already present and now duplicated on mobile). A close button at this position is a common UI pattern, so I didn't open an issue at first. I also emphasized that the Clear button triggers a destructive action.

This is what the updated queue looks like:

Desktop: Screenshot_2021-01-03___Pop_Snot___Viktor_Vaughn_____Album___Funkwhale

Mobile: Screenshot_2021-01-03___Pop_Snot___Viktor_Vaughn_____Album___Funkwhale_1_:

Edited Jan 03, 2021 by heyarne
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: funkwhale/funkwhale!1260
Source branch: feature/player-improvements

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.