Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 409
    • Issues 409
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1260

Small Player / Queue Improvements

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged heyarne requested to merge heyarne/funkwhale:feature/player-improvements into develop Jan 03, 2021
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 2

While technically these are two unrelated changes I felt like they were small enough to group them together in one merge request:

  1. There currently is an underlined whitespace before the album name in the player and the queue which is removed by c2587e0a
  2. I found it to be quite confusing at first to find out how to close the queue. The ESC button is meaningful enough to just try it out, but this commit adds an explicit button (which is already present and now duplicated on mobile). A close button at this position is a common UI pattern, so I didn't open an issue at first. I also emphasized that the Clear button triggers a destructive action.

This is what the updated queue looks like:

Desktop: Screenshot_2021-01-03___Pop_Snot___Viktor_Vaughn_____Album___Funkwhale

Mobile: Screenshot_2021-01-03___Pop_Snot___Viktor_Vaughn_____Album___Funkwhale_1_:

Edited Jan 03, 2021 by heyarne
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/player-improvements