Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 379
    • Issues 379
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1256

Resolve "Following channel with fediverse address not working"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge 1294-following-channel-with-fediverse-address-not-working into develop Dec 04, 2020
  • Overview 0
  • Commits 4
  • Pipelines 5
  • Changes 7

Closes #1294 (closed) Closes #1295 (closed)

Currently the feed type 'RSS' is explicitly passed in the subscriptions page and podcast page. This means that unless the user makes use of the search bar they cannot easily paste in fediverse addresses.

This change adds a check to see if the type is undefined or both, and presents the user the option to choose either rss or artists to ensure that they can subscribe to both types of channel easily.

Peek_2020-12-04_12-56

Also adds a change to the Modal focus trap to ensure it is deactivated on modal close, otherwise elements cannot be interacted-with after opening a modal.

Edited Dec 04, 2020 by Ciarán Ainsworth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1294-following-channel-with-fediverse-address-not-working