Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 396
    • Issues 396
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1178

Fix issue with album and artist search page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge fix-search-page-bug into develop Jul 25, 2020
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 3

Currently, the artist and album search pages have an interesting bug when searching through pages and then applying searches.

Steps to replicate

  • Go to open.audio
  • Go to the artist search page
  • Go to page 2
  • Type in a search for an artist like "Omri Lahav"

What is expected?

The artist should appear as they definitely exist

What happens?

The artist does not appear

This is because the page is updated when the pagination is used, which means the form submission is actually searching for page 2 of the paginated search results. This MR introduces a simple fix to reset the value of page when the form is submitted so that any new search term automatically defaults to the first page.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-search-page-bug