Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • funkwhale funkwhale
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 410
    • Issues 410
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • funkwhalefunkwhale
  • Merge requests
  • !1129

Fix support for Python 3.5 in import script

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ciarán Ainsworth requested to merge fix-import-python-3-5 into develop Jun 02, 2020
  • Overview 2
  • Commits 4
  • Pipelines 4
  • Changes 2

Fix #1148 (closed) and #1147 (closed) XXX

This Merge Request includes:

  • A changelog fragment (cf https://docs.funkwhale.audio/contributing.html#changelog-management)

This MR fixes compatibility with Python < 3.6. The os.scandir() method didn't receive context support until 3.6, so users of Debian 9 (mostly Yunohost users) cannot run the script as of version 0.21 as seen in the above issues. Since we are supporting 3.5 until version 1.0, this should probably be fixed for 0.21.1.

This has been tested on my Yunohost server running Debian 9, Python 3.5.

CC @funkwhale/reviewers-python

Edited Jun 05, 2020 by Agate
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-import-python-3-5