Unclear that an upgrade to Redis 5 is needed for 1.0/1.0.1
Steps to reproduce
- Install Funkwhale 0.18 ages ago, with the multi-container Docker setup
- Upgrade release by release to 1.0.1, only making changes to the setup required by the changelog.
- Watch the console in
You get periodic
ERR unknown command 'BZPOPMIN' errors in the console when playing music.
What is expected?
The console should be free of errors.
Funkwhale version(s) affected: 1.0.1
With the old multi-container Docker setup, upgrading to Redis 5 is required to fix complaints about
ERR unknown command 'BZPOPMIN' in the console when upgrading to Funkwhale 1.0.1 from 0.21.2. However, I didn't see anything about this in the changelog, so after I set everything to 1.0.1 I started up against Redis 3 and got these alarming messages in the console. (I didn't notice these messages in 0.21.2, but they might still have been there.)
It looks like the docker-compose template was changed 9 moths ago, but I have my own customized docker-compose file and pulling in changes from that template hasn't always been part of my normal upgrade workflow, especially if nothing in the changelog suggests that it is necessary.
I think the Redis version in the template was bumped to 5 before 5 was actually a requirement, and then it wasn't noticed when 5 actually became a requirement and support for 3 was dropped.
A changelog entry should be added saying that Redis 5 is needed.