fix(a11y): Add aria labels to links to make clear where they are heading to

approved this merge request

Looks good to me!

assigned to @georgkrause

I got feedback regarding this one:

Regarding your last point: Unfortunately, overwriting an elements' text by adding an aria-label is not possible. That only works when an element does not have a content body. So what you’d need to use is a construct like the following:

<span class=visual styling>
  <span aria-hidden=true>visual text</span>
  <span aria-label=assistive technology text></span>
</span>

The reason why this is not supported natively is that, in almost all cases where this might be used, you actually need to make sure that both the visual representation of a site and an assistive technology version exhibit the exact same interface, as they are oftentimes used in combination and any inconsistencies here might throw people off.

However, in your case, this would be okay as there is other visual context surrounding it.

I therefore have to rework this

added 1 commit

• 90f42ade - fix(a11y): Add aria labels to links to make clear where they are heading to

Compare with previous version

requested review from @Sporiff

added 22 commits

• 90f42ade...7b8ff7ba - 21 commits from branch main
• 2c4801a3 - fix(a11y): Add aria labels to links to make clear where they are heading to

Compare with previous version

added 3 commits

• 2c4801a3...bbf8c3e9 - 2 commits from branch main
• 565a8bf4 - fix(a11y): Add aria labels to links to make clear where they are heading to

Compare with previous version

assigned to @marge_me

unassigned @marge_me

I couldn't merge this branch: Sorry, I can't merge requests which have unresolved discussions!

resolved all threads

assigned to @marge_me

mentioned in commit 64a4a3db

added 1 commit

• 64a4a3db - fix(a11y): Add aria labels to links to make clear where they are heading to

Compare with previous version

unassigned @marge_me

I couldn't merge this branch: CI failed!

assigned to @marge_me

unassigned @marge_me

I couldn't merge this branch: CI failed!

assigned to @marge_me

unassigned @marge_me

I couldn't merge this branch: had some issue with GitLab, check my logs...

merged