Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Funkwhale Android Funkwhale Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 62
    • Issues 62
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • Funkwhale AndroidFunkwhale Android
  • Merge requests
  • !305

Transcoding at lower bitrate for limited bandwidth (#58)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Dylan Gageot requested to merge dgageot/funkwhale-android:bwLimitation into develop Jan 30, 2023
  • Overview 1
  • Commits 4
  • Pipelines 0
  • Changes 6

Hello!

To begin with, thanks a lot for Funkwhale and the Android application, which is delightful to use every day.

As mentioned in #58, the application does not yet have a way to reduce the amount of data exchanged between the player and the server. When streaming high-quality audio on 4G or 5G connection, it can get very costly if one does consume a lot of FLAC content. This PR is an attempt at solving this issue and is my first contribution to the project. I would appreciate some hints/helps according to unit tests, translations, and probably things I did not cover for the moment...

Here is a summary of what I have done:

  • Add a new setting called "Bandwidth limitation" with an icon, and a basic description,
  • If bandwidth limitation is set to limited, append &to=mp3&max_bitrate=320 to the listen URL of the candidate best track upload.

A better way to do it in the future would be to add a bar to configure the desired maximum bitrate, and probably check in the cache if the best upload is already there before asking for a reduced one. Testing that the best quality upload is already meeting the bandwidth constraint would be interesting to avoid an unneeded transcoding on the server side. I prefer to point out the flaws so that we can discuss about them together! 😄

Thank in advance,

Dylan

Edited Jan 30, 2023 by Dylan Gageot
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bwLimitation