Skip to content

Cleanup most build warnings.

Hugh Daschbach requested to merge hdasch/funkwhale-android:warnings-cleanup into develop

This patch stream aims to resolve most build warnings. Most of these resolve deprecation warnings where API documentation provides an obvious resolution. A few are a bit more complicated.

The last is the most disruptive. It replaces SimpleExoPlayer with ExoPlayer.

The "LoginActivity: startActivityForResult deprecated" includes an internal API change with an updated test.

Three classes of warnings remain:

  • Bus.kt uses GlobalScope, which is marked a "delicate" API. Its replacement is not obvious.
  • FFAFragment.kt complains about an "Unchecked cast". The correction action in this case eludes me.
  • MainActivity.kt uses defaultDisplay: Display! and getMetrics(DisplayMetrics") which are deprecated. But replacing defaultDisplay.getMetrics() with currentWindowMetrics.bounds requires API 30. So this will need to await another day.

This deserves some testing by someone other than the author. It seems stable, and, at least, "works for me". It is not a pressing issue, but a pushback against the second law of thermodynamics.

Merge request reports