Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Funkwhale Android Funkwhale Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhale
  • Funkwhale AndroidFunkwhale Android
  • Merge requests
  • !156

Close AuthorizationService leak.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Hugh Daschbach requested to merge hdasch/funkwhale-android:service-leak into develop May 07, 2022
  • Overview 4
  • Commits 3
  • Pipelines 2
  • Changes 2

Identifying android.app.ServiceConnectionLeaked exceptions in logcat output points to missing missing call to AuthorizationService.dispose() calls to clean up bindings to net.openid.appauth.browser.CustomTabManager.

This seems to be at least part of the cause of issue #102 (closed). Local testing continues, but testing these patches for four days, the submitter has not been forced to reauthenticate. Issue #102 (closed) has been hard to reproduce, so this may not be a final fix. But we think it deserves additional testing.

Note: the submitter is neither an Android, nor a Kotlin, developer. But he has been able to reproduce the token expiration fairly regularly, often with overnight testing in the AndroidStudio emulator. Please review the patch with this inexperience in mind.

Inspiration for third patch (Close AuthenticationService leak): service-leak.log)

Inspiration for second patch (Suppress update call in callback exception path): auth-exceptions.log. The extra exception detail in this log comes from the first patch (Embellish exception reporting).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: service-leak