Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • C cli
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • funkwhalefunkwhale
  • cli
  • Merge requests
  • !8

Fix hack incompatibility with cryptfile keyring

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adrian Petrescu requested to merge apetresc/cli:cryptfile-hack into master Mar 29, 2020
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

I'm not exactly sure what this hack was ever supposed to accomplish, but it's clearly unnecessary for dummy keyrings like keyrings.alt or keyrings.cryptfile. When I try to login, the CLI just crashes with an AttributeError on keyring.backend.get_all_keyring.__wrapped__.always_returns, which is what the hack is trying to remove anyway.

So this patch just skips trying to del the attribute if it already doesn't exist.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cryptfile-hack