Add basic model tests

@georgkrause I may be reading this wrong, but I don't think we're using the right serializers for the /api/v1/manage/{type}/{uuid}/stats endpoints. These seem to be using the type serializer the same as /api/v1/manage/{type}/{uuid}. I've included some example payloads to show what I mean.

This is pretty confusing now, maybe lets be more specific. Where do we use the wrong serializer?

In the api code? In the api specs? In the client lib?

Also, please let me know which payloads you are talking about, there are a lot :D

For example, look at the file funkwhale_api_client/api/manage/manage_library_libraries_stats_retrieve.py. In this file we have a GET operation that hits the endpoint /api/v1/manage/library/libraries/{uuid}/stats. It asserts the returned value should be a ManageLibrary object, but the result I get from that endpoint very clearly isn't. This is the same for the other stats endpoints. I'll push some tests to highlight this now.

Jeah, its a common problem. Just write the test to assert what you expect and I'll use it as starting point to fix the issue

added 1 commit

bafad5ce - Add note and report handling tests

Compare with previous version

added 1 commit

011418c5 - Fix subscriptions/all test

Compare with previous version

added 1 commit

2180841c - Add stats tests

Compare with previous version

added 2 commits

70324e80 - Add email verification test
3025d17c - Add more tests

Compare with previous version

added 2 commits

83cabe6f - Fix library tests
f2c319c6 - Fix formatting of test files

Compare with previous version

@Sporiff favorites_all.json is an empty file, is this intended?

Not intended , I've pushed it

added 1 commit

f8d9d3a7 - Add missing favorites_all information

Compare with previous version

@Sporiff How did you got upload_for_owner.json? The reply from my server looks totally different.

Huh, so does mine. I don't remember exactly what I hit for that response but I've updated the file to reflect the proper data. I'll go back and see if I can figure out what endpoint gave me that.

Reported in chat: Metadata endpoint

added 1 commit

a67ae040 - Mark test as expected to fail

Compare with previous version

Add basic model tests

Merge request reports

Activity