Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
funkwhale
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
codl
funkwhale
Commits
adbd9c3b
Commit
adbd9c3b
authored
2 years ago
by
Kasper Seweryn
Committed by
Marge
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
feat(service-worker): descriptive service-worker error
Part-of: <
funkwhale/funkwhale!2537
>
parent
54d8043e
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
changes/changelog.d/descriptive-service-worker-error.enchancement
+1
-0
1 addition, 0 deletions
...changelog.d/descriptive-service-worker-error.enchancement
front/src/init/serviceWorker.ts
+15
-2
15 additions, 2 deletions
front/src/init/serviceWorker.ts
with
16 additions
and
2 deletions
changes/changelog.d/descriptive-service-worker-error.enchancement
0 → 100644
+
1
−
0
View file @
adbd9c3b
Log service worker registration error and add a warning about Firefox SW incompatibility in development mode
This diff is collapsed.
Click to expand it.
front/src/init/serviceWorker.ts
+
15
−
2
View file @
adbd9c3b
...
...
@@ -10,8 +10,21 @@ const logger = useLogger()
export
const
install
:
InitModule
=
({
store
})
=>
{
const
updateSW
=
registerSW
({
onRegisterError
()
{
logger
.
error
(
'
SW install error
'
)
onRegisterError
(
error
)
{
const
importStatementsSupported
=
navigator
.
userAgent
.
includes
(
'
Chrome
'
)
||
navigator
.
userAgent
.
includes
(
'
Chromium
'
)
||
navigator
.
userAgent
.
includes
(
'
Opera
'
)
||
navigator
.
userAgent
.
includes
(
'
Brave
'
)
if
(
import
.
meta
.
env
.
DEV
&&
!
importStatementsSupported
)
{
logger
.
warn
(
'
Service Worker is not supported in your browser in development mode.
\n
'
,
'
For more information, please refer to
\'
Support for ECMAScript modules
\'
section at:
\n
'
,
'
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorker#browser_compatibility
'
)
}
logger
.
error
(
'
Service Worker install error:
'
,
error
)
},
onOfflineReady
()
{
logger
.
info
(
'
Funkwhale is being served from cache by a service worker.
'
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment