Merge branch '240-pagination' into 'develop'

Resolve "50 results per page returns 25"

Closes #240

See merge request funkwhale/funkwhale!218

api/funkwhale_api/common/pagination.py

@@ -3,4 +3,4 @@ from rest_framework.pagination import PageNumberPagination
 
 class FunkwhalePagination(PageNumberPagination):
     page_size_query_param = 'page_size'
-    max_page_size = 25
+    max_page_size = 50

api/funkwhale_api/favorites/views.py

@@ -12,12 +12,6 @@ from . import models
 from . import serializers
 
 
-class CustomLimitPagination(pagination.PageNumberPagination):
-    page_size = 100
-    page_size_query_param = 'page_size'
-    max_page_size = 100
-
-
 class TrackFavoriteViewSet(mixins.CreateModelMixin,
                            mixins.DestroyModelMixin,
                            mixins.ListModelMixin,
@@ -26,7 +20,6 @@ class TrackFavoriteViewSet(mixins.CreateModelMixin,
     serializer_class = serializers.UserTrackFavoriteSerializer
     queryset = (models.TrackFavorite.objects.all())
     permission_classes = [ConditionalAuthentication]
-    pagination_class = CustomLimitPagination
 
     def create(self, request, *args, **kwargs):
         serializer = self.get_serializer(data=request.data)

changes/changelog.d/240.bugfix

+Fixed ignored page_size paremeter on artist and favorites list (#240)

front/src/components/favorites/List.vue

@@ -136,19 +136,15 @@ export default {
   watch: {
     page: function () {
       this.updateQueryString()
-      this.fetchFavorites(FAVORITES_URL)
     },
     paginateBy: function () {
       this.updateQueryString()
-      this.fetchFavorites(FAVORITES_URL)
     },
     orderingDirection: function () {
       this.updateQueryString()
-      this.fetchFavorites(FAVORITES_URL)
     },
     ordering: function () {
       this.updateQueryString()
-      this.fetchFavorites(FAVORITES_URL)
     }
   }
 }