From 17de77695984e6b76ee91fbc7a9ca8252d8e634a Mon Sep 17 00:00:00 2001
From: Eliot Berriot <contact@eliotberriot.com>
Date: Fri, 13 Sep 2019 06:05:48 +0200
Subject: [PATCH] See #890: ensure no emails are sent to non-mods or inactive
users
---
api/tests/moderation/test_tasks.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/api/tests/moderation/test_tasks.py b/api/tests/moderation/test_tasks.py
index 18e031fd..a4f28779 100644
--- a/api/tests/moderation/test_tasks.py
+++ b/api/tests/moderation/test_tasks.py
@@ -17,6 +17,8 @@ def test_report_created_signal_sends_email_to_mods(factories, mailoutbox, settin
mod2 = factories["users.User"](permission_moderation=True)
# inactive, so no email
factories["users.User"](permission_moderation=True, is_active=False)
+ # no moderation permission, so no email
+ factories["users.User"]()
report = factories["moderation.Report"]()
@@ -28,6 +30,7 @@ def test_report_created_signal_sends_email_to_mods(factories, mailoutbox, settin
unresolved_reports_url = federation_utils.full_url(
"/manage/moderation/reports?q=resolved:no"
)
+ assert len(mailoutbox) == 2
for i, mod in enumerate([mod1, mod2]):
m = mailoutbox[i]
assert m.subject == "[{} moderation - {}] New report from {}".format(
--
GitLab