From 7bcb8d8c8940efb6edfd65b35a68e246797b036c Mon Sep 17 00:00:00 2001
From: Fanyx <fanyx@pm.me>
Date: Sun, 28 Mar 2021 19:21:01 +0200
Subject: [PATCH] change struct to reflect subsonic api specs, fixes #1374
---
api/funkwhale_api/subsonic/serializers.py | 2 +-
api/tests/subsonic/test_views.py | 3 +--
changes/changelog.d/fix_getuser_serializer.bugfix | 3 +++
3 files changed, 5 insertions(+), 3 deletions(-)
create mode 100644 changes/changelog.d/fix_getuser_serializer.bugfix
diff --git a/api/funkwhale_api/subsonic/serializers.py b/api/funkwhale_api/subsonic/serializers.py
index d7042718af..5d3990bafa 100644
--- a/api/funkwhale_api/subsonic/serializers.py
+++ b/api/funkwhale_api/subsonic/serializers.py
@@ -264,7 +264,7 @@ def get_user_detail_data(user):
"playlistRole": "true",
"streamRole": "true",
"jukeboxRole": "true",
- "folder": [{"value": f["id"]} for f in get_folders(user)],
+ "folder": [f["id"] for f in get_folders(user)],
}
diff --git a/api/tests/subsonic/test_views.py b/api/tests/subsonic/test_views.py
index d8bc5aeebb..5f28b1fea8 100644
--- a/api/tests/subsonic/test_views.py
+++ b/api/tests/subsonic/test_views.py
@@ -810,8 +810,7 @@ def test_get_user(f, db, logged_in_api_client, factories):
"coverArtRole": "false",
"shareRole": "false",
"folder": [
- {"value": f["id"]}
- for f in serializers.get_folders(logged_in_api_client.user)
+ f["id"] for f in serializers.get_folders(logged_in_api_client.user)
],
}
}
diff --git a/changes/changelog.d/fix_getuser_serializer.bugfix b/changes/changelog.d/fix_getuser_serializer.bugfix
new file mode 100644
index 0000000000..562271a751
--- /dev/null
+++ b/changes/changelog.d/fix_getuser_serializer.bugfix
@@ -0,0 +1,3 @@
+issue="1374"
+content="Fixed a small discrepancy to the subsonic api"
+category="bugfix"
\ No newline at end of file
--
GitLab