Verified Commit 0d3df8ab authored by Eliot Berriot's avatar Eliot Berriot
Browse files

Fix #970: short audio glitch when switching switching to another track with player paused

parent 7c8b592f
Fixed short audio glitch when switching switching to another track with player paused (#970)
......@@ -361,7 +361,7 @@ export default {
self.ended()
},
onunlock: function () {
if (self.$store.state.player.playing) {
if (self.$store.state.player.playing && self.sound) {
self.soundId = self.sound.play(self.soundId)
}
},
......@@ -581,13 +581,11 @@ export default {
}
this.currentSound = this.getSound(trackData)
this.$store.commit('player/isLoadingAudio', true)
if (this.playing) {
this.soundId = this.currentSound.play()
this.$store.commit('player/errored', false)
this.$store.commit('player/playing', true)
this.$store.dispatch('player/updateProgress', 0)
this.observeProgress(true)
}
this.soundId = this.currentSound.play()
this.$store.commit('player/errored', false)
this.$store.commit('player/playing', true)
this.$store.dispatch('player/updateProgress', 0)
this.observeProgress(true)
}
},
toggleMobilePlayer () {
......
......@@ -140,7 +140,6 @@ export default {
currentIndex ({commit, state, rootState, dispatch}, index) {
commit('ended', false)
commit('player/currentTime', 0, {root: true})
commit('player/playing', true, {root: true})
commit('currentIndex', index)
if (state.tracks.length - index <= 2 && rootState.radios.running) {
dispatch('radios/populateQueue', null, {root: true})
......
......@@ -226,7 +226,6 @@ describe('store/queue', () => {
expectedMutations: [
{ type: 'ended', payload: false },
{ type: 'player/currentTime', payload: 0, options: {root: true} },
{ type: 'player/playing', payload: true, options: {root: true} },
{ type: 'currentIndex', payload: 1 }
]
})
......@@ -239,7 +238,6 @@ describe('store/queue', () => {
expectedMutations: [
{ type: 'ended', payload: false },
{ type: 'player/currentTime', payload: 0, options: {root: true} },
{ type: 'player/playing', payload: true, options: {root: true} },
{ type: 'currentIndex', payload: 1 }
]
})
......@@ -252,7 +250,6 @@ describe('store/queue', () => {
expectedMutations: [
{ type: 'ended', payload: false },
{ type: 'player/currentTime', payload: 0, options: {root: true} },
{ type: 'player/playing', payload: true, options: {root: true} },
{ type: 'currentIndex', payload: 1 }
],
expectedActions: [
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment