Verified Commit e9a3c37a authored by Eliot Berriot's avatar Eliot Berriot
Browse files

Merge branch 'release/0.2.3'

parents e17aee29 4be052c0
...@@ -54,6 +54,7 @@ THIRD_PARTY_APPS = ( ...@@ -54,6 +54,7 @@ THIRD_PARTY_APPS = (
'rest_auth.registration', 'rest_auth.registration',
'mptt', 'mptt',
'dynamic_preferences', 'dynamic_preferences',
'django_filters',
) )
# Apps specific for this project go here. # Apps specific for this project go here.
...@@ -298,7 +299,7 @@ REST_FRAMEWORK = { ...@@ -298,7 +299,7 @@ REST_FRAMEWORK = {
'DEFAULT_PERMISSION_CLASSES': ( 'DEFAULT_PERMISSION_CLASSES': (
'rest_framework.permissions.IsAuthenticated', 'rest_framework.permissions.IsAuthenticated',
), ),
'DEFAULT_PAGINATION_CLASS': 'rest_framework.pagination.PageNumberPagination', 'DEFAULT_PAGINATION_CLASS': 'funkwhale_api.common.pagination.FunkwhalePagination',
'PAGE_SIZE': 25, 'PAGE_SIZE': 25,
'DEFAULT_AUTHENTICATION_CLASSES': ( 'DEFAULT_AUTHENTICATION_CLASSES': (
...@@ -309,6 +310,7 @@ REST_FRAMEWORK = { ...@@ -309,6 +310,7 @@ REST_FRAMEWORK = {
), ),
'DEFAULT_FILTER_BACKENDS': ( 'DEFAULT_FILTER_BACKENDS': (
'rest_framework.filters.OrderingFilter', 'rest_framework.filters.OrderingFilter',
'django_filters.rest_framework.DjangoFilterBackend',
) )
} }
......
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
__version__ = '0.2.2' __version__ = '0.2.3'
__version_info__ = tuple([int(num) if num.isdigit() else num for num in __version__.replace('-', '.', 1).split('.')]) __version_info__ = tuple([int(num) if num.isdigit() else num for num in __version__.replace('-', '.', 1).split('.')])
from rest_framework.pagination import PageNumberPagination
class FunkwhalePagination(PageNumberPagination):
page_size_query_param = 'page_size'
max_page_size = 25
"""
Populates the database with fake data
"""
import random
from funkwhale_api.music import models
from funkwhale_api.music.tests import factories
def create_data(count=25):
artists = factories.ArtistFactory.create_batch(size=count)
for artist in artists:
print('Creating data for', artist)
albums = factories.AlbumFactory.create_batch(
artist=artist, size=random.randint(1, 5))
for album in albums:
factories.TrackFileFactory.create_batch(
track__album=album, size=random.randint(3, 18))
if __name__ == '__main__':
main()
import django_filters
from . import models
class ArtistFilter(django_filters.FilterSet):
class Meta:
model = models.Artist
fields = {
'name': ['exact', 'iexact', 'startswith']
}
...@@ -5,7 +5,7 @@ SAMPLES_PATH = os.path.dirname(os.path.abspath(__file__)) ...@@ -5,7 +5,7 @@ SAMPLES_PATH = os.path.dirname(os.path.abspath(__file__))
class ArtistFactory(factory.django.DjangoModelFactory): class ArtistFactory(factory.django.DjangoModelFactory):
name = factory.Sequence(lambda n: 'artist-{0}'.format(n)) name = factory.Faker('name')
mbid = factory.Faker('uuid4') mbid = factory.Faker('uuid4')
class Meta: class Meta:
...@@ -13,7 +13,7 @@ class ArtistFactory(factory.django.DjangoModelFactory): ...@@ -13,7 +13,7 @@ class ArtistFactory(factory.django.DjangoModelFactory):
class AlbumFactory(factory.django.DjangoModelFactory): class AlbumFactory(factory.django.DjangoModelFactory):
title = factory.Sequence(lambda n: 'album-{0}'.format(n)) title = factory.Faker('sentence', nb_words=3)
mbid = factory.Faker('uuid4') mbid = factory.Faker('uuid4')
release_date = factory.Faker('date') release_date = factory.Faker('date')
cover = factory.django.ImageField() cover = factory.django.ImageField()
...@@ -24,7 +24,7 @@ class AlbumFactory(factory.django.DjangoModelFactory): ...@@ -24,7 +24,7 @@ class AlbumFactory(factory.django.DjangoModelFactory):
class TrackFactory(factory.django.DjangoModelFactory): class TrackFactory(factory.django.DjangoModelFactory):
title = factory.Sequence(lambda n: 'track-{0}'.format(n)) title = factory.Faker('sentence', nb_words=3)
mbid = factory.Faker('uuid4') mbid = factory.Faker('uuid4')
album = factory.SubFactory(AlbumFactory) album = factory.SubFactory(AlbumFactory)
artist = factory.SelfAttribute('album.artist') artist = factory.SelfAttribute('album.artist')
......
...@@ -182,6 +182,21 @@ class TestAPI(TMPDirTestCaseMixin, TestCase): ...@@ -182,6 +182,21 @@ class TestAPI(TMPDirTestCaseMixin, TestCase):
self.assertJSONEqual(expected, json.loads(response.content.decode('utf-8'))) self.assertJSONEqual(expected, json.loads(response.content.decode('utf-8')))
def test_can_search_artist_by_name_start(self):
artist1 = factories.ArtistFactory(name='alpha')
artist2 = factories.ArtistFactory(name='beta')
results = {
'next': None,
'previous': None,
'count': 1,
'results': [serializers.ArtistSerializerNested(artist1).data]
}
expected = json.dumps(results)
url = self.reverse('api:v1:artists-list')
response = self.client.get(url, {'name__startswith': 'a'})
self.assertJSONEqual(expected, json.loads(response.content.decode('utf-8')))
def test_can_search_tracks(self): def test_can_search_tracks(self):
artist1 = models.Artist.objects.create(name='Test1') artist1 = models.Artist.objects.create(name='Test1')
artist2 = models.Artist.objects.create(name='Test2') artist2 = models.Artist.objects.create(name='Test2')
......
...@@ -21,8 +21,10 @@ from taggit.models import Tag ...@@ -21,8 +21,10 @@ from taggit.models import Tag
from . import models from . import models
from . import serializers from . import serializers
from . import importers from . import importers
from . import filters
from . import utils from . import utils
class SearchMixin(object): class SearchMixin(object):
search_fields = [] search_fields = []
...@@ -52,7 +54,8 @@ class ArtistViewSet(SearchMixin, viewsets.ReadOnlyModelViewSet): ...@@ -52,7 +54,8 @@ class ArtistViewSet(SearchMixin, viewsets.ReadOnlyModelViewSet):
serializer_class = serializers.ArtistSerializerNested serializer_class = serializers.ArtistSerializerNested
permission_classes = [ConditionalAuthentication] permission_classes = [ConditionalAuthentication]
search_fields = ['name'] search_fields = ['name']
ordering_fields = ('creation_date',) ordering_fields = ('creation_date', 'name')
filter_class = filters.ArtistFilter
class AlbumViewSet(SearchMixin, viewsets.ReadOnlyModelViewSet): class AlbumViewSet(SearchMixin, viewsets.ReadOnlyModelViewSet):
......
...@@ -45,6 +45,7 @@ django-taggit==0.22.1 ...@@ -45,6 +45,7 @@ django-taggit==0.22.1
persisting-theory==0.2.1 persisting-theory==0.2.1
django-versatileimagefield==1.7.1 django-versatileimagefield==1.7.1
django-cachalot==1.5.0 django-cachalot==1.5.0
django-filter==1.1
django-rest-auth==0.9.1 django-rest-auth==0.9.1
beautifulsoup4==4.6.0 beautifulsoup4==4.6.0
Markdown==2.6.8 Markdown==2.6.8
......
...@@ -16,9 +16,10 @@ ...@@ -16,9 +16,10 @@
"dependencies": { "dependencies": {
"dateformat": "^2.0.0", "dateformat": "^2.0.0",
"js-logger": "^1.3.0", "js-logger": "^1.3.0",
"lodash": "^4.17.4",
"semantic-ui-css": "^2.2.10", "semantic-ui-css": "^2.2.10",
"vue": "^2.3.3", "vue": "^2.3.3",
"vue-global-events": "^1.0.2", "vue-lazyload": "^1.1.4",
"vue-resource": "^1.3.4", "vue-resource": "^1.3.4",
"vue-router": "^2.3.1", "vue-router": "^2.3.1",
"vuedraggable": "^2.14.1" "vuedraggable": "^2.14.1"
......
<template>
<div class="ui pagination borderless menu">
<a
@click="selectPage(1)"
:class="[{'disabled': current === 1}, 'item']"><i class="angle double left icon"></i></a>
<a
@click="selectPage(current - 1)"
:class="[{'disabled': current - 1 < 1}, 'item']"><i class="angle left icon"></i></a>
<a
v-for="page in pages"
@click="selectPage(page)"
:class="[{'active': page === current}, 'item']">
{{ page }}
</a>
<a
@click="selectPage(current + 1)"
:class="[{'disabled': current + 1 > maxPage}, 'item']"><i class="angle right icon"></i></a>
<a
@click="selectPage(maxPage)"
:class="[{'disabled': current === maxPage}, 'item']"><i class="angle double right icon"></i></a>
</div>
</template>
<script>
import _ from 'lodash'
export default {
props: {
current: {type: Number, default: 1},
paginateBy: {type: Number, default: 25},
total: {type: Number}
},
computed: {
pages: function () {
return _.range(1, this.maxPage + 1)
},
maxPage: function () {
return Math.ceil(this.total / this.paginateBy)
}
},
methods: {
selectPage: function (page) {
if (this.current !== page) {
this.$emit('page-changed', page)
}
}
}
}
</script>
<style scoped>
</style>
...@@ -94,7 +94,7 @@ ...@@ -94,7 +94,7 @@
</template> </template>
<script> <script>
import GlobalEvents from 'vue-global-events' import GlobalEvents from '@/components/utils/global-events'
import Player from '@/components/audio/Player' import Player from '@/components/audio/Player'
import favoriteTracks from '@/favorites/tracks' import favoriteTracks from '@/favorites/tracks'
......
...@@ -7,14 +7,14 @@ ...@@ -7,14 +7,14 @@
<img v-else src="../../assets/audio/default-cover.png"> <img v-else src="../../assets/audio/default-cover.png">
</div> </div>
<div class="middle aligned content"> <div class="middle aligned content">
<router-link class="small header discrete link track" :to="{name: 'library.track', params: {id: queue.currentTrack.id }}"> <router-link class="small header discrete link track" :to="{name: 'library.tracks.detail', params: {id: queue.currentTrack.id }}">
{{ queue.currentTrack.title }} {{ queue.currentTrack.title }}
</router-link> </router-link>
<div class="meta"> <div class="meta">
<router-link class="artist" :to="{name: 'library.artist', params: {id: queue.currentTrack.artist.id }}"> <router-link class="artist" :to="{name: 'library.artists.detail', params: {id: queue.currentTrack.artist.id }}">
{{ queue.currentTrack.artist.name }} {{ queue.currentTrack.artist.name }}
</router-link> / </router-link> /
<router-link class="album" :to="{name: 'library.album', params: {id: queue.currentTrack.album.id }}"> <router-link class="album" :to="{name: 'library.albums.detail', params: {id: queue.currentTrack.album.id }}">
{{ queue.currentTrack.album.title }} {{ queue.currentTrack.album.title }}
</router-link> </router-link>
</div> </div>
...@@ -68,7 +68,7 @@ ...@@ -68,7 +68,7 @@
</template> </template>
<script> <script>
import GlobalEvents from 'vue-global-events' import GlobalEvents from '@/components/utils/global-events'
import queue from '@/audio/queue' import queue from '@/audio/queue'
import Track from '@/audio/track' import Track from '@/audio/track'
......
...@@ -35,7 +35,7 @@ export default { ...@@ -35,7 +35,7 @@ export default {
let categories = [ let categories = [
{ {
code: 'artists', code: 'artists',
route: 'library.artist', route: 'library.artists.detail',
name: 'Artist', name: 'Artist',
getTitle (r) { getTitle (r) {
return r.name return r.name
...@@ -46,7 +46,7 @@ export default { ...@@ -46,7 +46,7 @@ export default {
}, },
{ {
code: 'albums', code: 'albums',
route: 'library.album', route: 'library.albums.detail',
name: 'Album', name: 'Album',
getTitle (r) { getTitle (r) {
return r.title return r.title
...@@ -57,7 +57,7 @@ export default { ...@@ -57,7 +57,7 @@ export default {
}, },
{ {
code: 'tracks', code: 'tracks',
route: 'library.track', route: 'library.tracks.detail',
name: 'Track', name: 'Track',
getTitle (r) { getTitle (r) {
return r.title return r.title
......
...@@ -2,14 +2,14 @@ ...@@ -2,14 +2,14 @@
<div class="ui card"> <div class="ui card">
<div class="content"> <div class="content">
<div class="right floated tiny ui image"> <div class="right floated tiny ui image">
<img v-if="album.cover" :src="backend.absoluteUrl(album.cover)"> <img v-if="album.cover" v-lazy="backend.absoluteUrl(album.cover)">
<img v-else src="../../../assets/audio/default-cover.png"> <img v-else src="../../../assets/audio/default-cover.png">
</div> </div>
<div class="header"> <div class="header">
<router-link class="discrete link" :to="{name: 'library.album', params: {id: album.id }}">{{ album.title }}</router-link> <router-link class="discrete link" :to="{name: 'library.albums.detail', params: {id: album.id }}">{{ album.title }}</router-link>
</div> </div>
<div class="meta"> <div class="meta">
By <router-link :to="{name: 'library.artist', params: {id: album.artist.id }}"> By <router-link :to="{name: 'library.artists.detail', params: {id: album.artist.id }}">
{{ album.artist.name }} {{ album.artist.name }}
</router-link> </router-link>
</div> </div>
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
<play-button class="basic icon" :track="track" :discrete="true"></play-button> <play-button class="basic icon" :track="track" :discrete="true"></play-button>
</td> </td>
<td colspan="6"> <td colspan="6">
<router-link class="track discrete link" :to="{name: 'library.track', params: {id: track.id }}"> <router-link class="track discrete link" :to="{name: 'library.tracks.detail', params: {id: track.id }}">
<template v-if="track.position"> <template v-if="track.position">
{{ track.position }}. {{ track.position }}.
</template> </template>
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
<div class="ui card"> <div class="ui card">
<div class="content"> <div class="content">
<div class="header"> <div class="header">
<router-link class="discrete link" :to="{name: 'library.artist', params: {id: artist.id }}"> <router-link class="discrete link" :to="{name: 'library.artists.detail', params: {id: artist.id }}">
{{ artist.name }} {{ artist.name }}
</router-link> </router-link>
</div> </div>
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
<img class="ui mini image" v-else src="../../../assets/audio/default-cover.png"> <img class="ui mini image" v-else src="../../../assets/audio/default-cover.png">
</td> </td>
<td colspan="4"> <td colspan="4">
<router-link class="discrete link":to="{name: 'library.album', params: {id: album.id }}"> <router-link class="discrete link":to="{name: 'library.albums.detail', params: {id: album.id }}">
<strong>{{ album.title }}</strong> <strong>{{ album.title }}</strong>
</router-link><br /> </router-link><br />
{{ album.tracks.length }} tracks {{ album.tracks.length }} tracks
......
...@@ -16,11 +16,11 @@ ...@@ -16,11 +16,11 @@
<play-button class="basic icon" :discrete="true" :track="track"></play-button> <play-button class="basic icon" :discrete="true" :track="track"></play-button>
</td> </td>
<td> <td>
<img class="ui mini image" v-if="track.album.cover" :src="backend.absoluteUrl(track.album.cover)"> <img class="ui mini image" v-if="track.album.cover" v-lazy="backend.absoluteUrl(track.album.cover)">
<img class="ui mini image" v-else src="../../..//assets/audio/default-cover.png"> <img class="ui mini image" v-else src="../../..//assets/audio/default-cover.png">
</td> </td>
<td colspan="6"> <td colspan="6">
<router-link class="track" :to="{name: 'library.track', params: {id: track.id }}"> <router-link class="track" :to="{name: 'library.tracks.detail', params: {id: track.id }}">
<template v-if="displayPosition && track.position"> <template v-if="displayPosition && track.position">
{{ track.position }}. {{ track.position }}.
</template> </template>
...@@ -28,12 +28,12 @@ ...@@ -28,12 +28,12 @@
</router-link> </router-link>
</td> </td>
<td colspan="6"> <td colspan="6">
<router-link class="artist discrete link" :to="{name: 'library.artist', params: {id: track.artist.id }}"> <router-link class="artist discrete link" :to="{name: 'library.artists.detail', params: {id: track.artist.id }}">
{{ track.artist.name }} {{ track.artist.name }}
</router-link> </router-link>
</td> </td>
<td colspan="6"> <td colspan="6">
<router-link class="album discrete link" :to="{name: 'library.album', params: {id: track.album.id }}"> <router-link class="album discrete link" :to="{name: 'library.albums.detail', params: {id: track.album.id }}">
{{ track.album.title }} {{ track.album.title }}
</router-link> </router-link>
</td> </td>
......
...@@ -12,11 +12,16 @@ ...@@ -12,11 +12,16 @@
</div> </div>
<div class="ui vertical stripe segment"> <div class="ui vertical stripe segment">
<button class="ui left floated labeled icon button" @click="fetchFavorites(previousLink)" :disabled="!previousLink"><i class="left arrow icon"></i> Previous</button>
<button class="ui right floated right labeled icon button" @click="fetchFavorites(nextLink)" :disabled="!nextLink">Next <i class="right arrow icon"></i></button>
<div class="ui hidden clearing divider"></div>
<div class="ui hidden clearing divider"></div>
<track-table v-if="results" :tracks="results.results"></track-table> <track-table v-if="results" :tracks="results.results"></track-table>
<div class="ui center aligned basic segment">
<pagination
v-if="results && results.count > 0"
@page-changed="selectPage"
:current="page"
:paginate-by="paginateBy"
:total="results.count"
></pagination>
</div>
</div> </div>
</div> </div>
</template> </template>
...@@ -28,13 +33,15 @@ import config from '@/config' ...@@ -28,13 +33,15 @@ import config from '@/config'
import favoriteTracks from '@/favorites/tracks' import favoriteTracks from '@/favorites/tracks'
import TrackTable from '@/components/audio/track/Table' import TrackTable from '@/components/audio/track/Table'
import RadioButton from '@/components/radios/Button' import RadioButton from '@/components/radios/Button'
import Pagination from '@/components/Pagination'
const FAVORITES_URL = config.API_URL + 'tracks/' const FAVORITES_URL = config.API_URL + 'tracks/'
export default { export default {
components: { components: {
TrackTable, TrackTable,
RadioButton RadioButton,
Pagination
}, },
data () { data () {
return { return {
...@@ -42,6 +49,8 @@ export default { ...@@ -42,6 +49,8 @@ export default {
isLoading: false, isLoading: false,
nextLink: null, nextLink: null,
previousLink: null, previousLink: null,
page: 1,
paginateBy: 25,
favoriteTracks favoriteTracks
} }
}, },
...@@ -53,7 +62,9 @@ export default { ...@@ -53,7 +62,9 @@ export default {
var self = this var self = this
this.isLoading = true this.isLoading = true
let params = { let params = {
favorites: 'true' favorites: 'true',
page: this.page,
page_size: this.paginateBy
} }
logger.default.time('Loading user favorites') logger.default.time('Loading user favorites')
this.$http.get(url, {params: params}).then((response) => { this.$http.get(url, {params: params}).then((response) => {
...@@ -68,6 +79,14 @@ export default { ...@@ -68,6 +79,14 @@ export default {
logger.default.timeEnd('Loading user favorites') logger.default.timeEnd('Loading user favorites')
self.isLoading = false self.isLoading = false
}) })
},
selectPage: function (page) {
this.page = page
}
},
watch: {
page: function () {
this.fetchFavorites(FAVORITES_URL)
} }
} }
} }
......
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
{{ album.title }} {{ album.title }}
<div class="sub header"> <div class="sub header">
Album containing {{ album.tracks.length }} tracks, Album containing {{ album.tracks.length }} tracks,
by <router-link :to="{name: 'library.artist', params: {id: album.artist.id }}"> by <router-link :to="{name: 'library.artists.detail', params: {id: album.artist.id }}">
{{ album.artist.name }} {{ album.artist.name }}
</router-link> </router-link>
</div>