diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4ddde5b79e6568b12e49ef6d37af368b481ac9b9..57b7dfc7f83ce2dfa7f95295c4f323d7e5f27108 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -28,7 +28,7 @@ review_front: - yarn run i18n-compile # this is to ensure we don't have any errors in the output, # cf https://code.eliotberriot.com/funkwhale/funkwhale/issues/169 - - INSTANCE_URL=$REVIEW_INSTANCE_URL yarn run build | tee /dev/stderr | (! grep -i 'ERROR in') + - VUE_APP_INSTANCE_URL=$REVIEW_INSTANCE_URL yarn run build | tee /dev/stderr | (! grep -i 'ERROR in') - mkdir -p /static/front/$CI_PROJECT_PATH_SLUG-$CI_BUILD_REF_SLUG - cp -r dist/* /static/front/$CI_PROJECT_PATH_SLUG-$CI_BUILD_REF_SLUG cache: diff --git a/CHANGELOG b/CHANGELOG index 9ef9fd667ccda74cfca125db195c0b89ff127e8d..7fcaceaf4c345f37ea64e70b48ffacaaec20b304 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -10,6 +10,20 @@ This changelog is viewable on the web at https://docs.funkwhale.audio/changelog. .. towncrier +0.16.2 (2018-08-21) +------------------- + +Upgrade instructions are available at +https://docs.funkwhale.audio/upgrading.html + +Bugfixes: + +- Ensure we always have a default api url set on first load to avoid displaying + the instance picker (#490) +- Fixed CLI importer syntax error because of async reserved keyword usage + (#494) + + 0.16.1 (2018-08-19) ------------------- diff --git a/api/funkwhale_api/__init__.py b/api/funkwhale_api/__init__.py index 4b0303cdc2451744bf1d1514e09ccbd0337dd7a5..b897028f20708029a4a1154fe40aaf30b234b173 100644 --- a/api/funkwhale_api/__init__.py +++ b/api/funkwhale_api/__init__.py @@ -1,5 +1,5 @@ # -*- coding: utf-8 -*- -__version__ = "0.16.1" +__version__ = "0.16.2" __version_info__ = tuple( [ int(num) if num.isdigit() else num diff --git a/api/funkwhale_api/providers/audiofile/management/commands/import_files.py b/api/funkwhale_api/providers/audiofile/management/commands/import_files.py index 2aba0c145d1034e48aee3e706558731730dd2e9c..625f9c2f0736ab935d5c388715f5c85a8fbfc2f7 100644 --- a/api/funkwhale_api/providers/audiofile/management/commands/import_files.py +++ b/api/funkwhale_api/providers/audiofile/management/commands/import_files.py @@ -216,8 +216,8 @@ class Command(BaseCommand): message = "{i}/{total} Launching import for {path}..." # we create an import batch binded to the user - async = options["async"] - import_handler = tasks.import_job_run.delay if async else tasks.import_job_run + async_ = options["async"] + import_handler = tasks.import_job_run.delay if async_ else tasks.import_job_run batch = user.imports.create(source="shell") errors = [] for i, path in list(enumerate(paths)): diff --git a/front/src/App.vue b/front/src/App.vue index f80020e93931f376fb601a70dbd590569524dc13..c8134a4a0199d1fd1adf0f1b4066636cd6938635 100644 --- a/front/src/App.vue +++ b/front/src/App.vue @@ -124,12 +124,13 @@ export default { // used to redraw ago dates every minute self.$store.commit('ui/computeLastDate') }, 1000 * 60) - if (this.$store.state.instance.instanceUrl) { - this.$store.commit('instance/instanceUrl', this.$store.state.instance.instanceUrl) - this.$store.dispatch('auth/check') - this.$store.dispatch('instance/fetchSettings') - this.fetchNodeInfo() + if (!this.$store.state.instance.instanceUrl) { + let defaultInstanceUrl = process.env.VUE_APP_INSTANCE_URL || this.$store.getters['instance/defaultUrl']() + this.$store.commit('instance/instanceUrl', defaultInstanceUrl) } + this.$store.dispatch('auth/check') + this.$store.dispatch('instance/fetchSettings') + this.fetchNodeInfo() }, methods: { fetchNodeInfo () { diff --git a/front/src/store/instance.js b/front/src/store/instance.js index 5610b0ec7fc48f69af1eb33180be7b49fbef351d..163c595e302a0997887862f913207b01be0bb3b2 100644 --- a/front/src/store/instance.js +++ b/front/src/store/instance.js @@ -14,7 +14,7 @@ export default { state: { maxEvents: 200, frontSettings: {}, - instanceUrl: process.env.INSTANCE_URL, + instanceUrl: process.env.VUE_APP_INSTANCE_URL, events: [], settings: { instance: {