Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Maxence Bothorel
funkwhale
Commits
16f631af
Verified
Commit
16f631af
authored
Mar 20, 2018
by
Eliot Berriot
Browse files
Performance optimization on playlisttrack serialization
parent
dd40a4c4
Changes
2
Hide whitespace changes
Inline
Side-by-side
api/funkwhale_api/playlists/models.py
View file @
16f631af
...
...
@@ -94,6 +94,15 @@ class Playlist(models.Model):
]
return
PlaylistTrack
.
objects
.
bulk_create
(
plts
)
class
PlaylistTrackQuerySet
(
models
.
QuerySet
):
def
for_nested_serialization
(
self
):
return
(
self
.
select_related
()
.
select_related
(
'track__album__artist'
)
.
prefetch_related
(
'track__tags'
,
'track__files'
,
'track__artist__albums__tracks__tags'
))
class
PlaylistTrack
(
models
.
Model
):
track
=
models
.
ForeignKey
(
...
...
@@ -105,6 +114,8 @@ class PlaylistTrack(models.Model):
Playlist
,
related_name
=
'playlist_tracks'
,
on_delete
=
models
.
CASCADE
)
creation_date
=
models
.
DateTimeField
(
default
=
timezone
.
now
)
objects
=
PlaylistTrackQuerySet
.
as_manager
()
class
Meta
:
ordering
=
(
'-playlist'
,
'index'
)
unique_together
=
(
'playlist'
,
'index'
)
...
...
api/funkwhale_api/playlists/views.py
View file @
16f631af
...
...
@@ -46,7 +46,7 @@ class PlaylistViewSet(
@
detail_route
(
methods
=
[
'get'
])
def
tracks
(
self
,
request
,
*
args
,
**
kwargs
):
playlist
=
self
.
get_object
()
plts
=
playlist
.
playlist_tracks
.
all
()
plts
=
playlist
.
playlist_tracks
.
all
()
.
for_nested_serialization
()
serializer
=
serializers
.
PlaylistTrackSerializer
(
plts
,
many
=
True
)
data
=
{
'count'
:
len
(
plts
),
...
...
@@ -65,6 +65,9 @@ class PlaylistViewSet(
except
exceptions
.
ValidationError
as
e
:
payload
=
{
'playlist'
:
e
.
detail
}
return
Response
(
payload
,
status
=
400
)
ids
=
[
p
.
id
for
p
in
plts
]
plts
=
models
.
PlaylistTrack
.
objects
.
filter
(
pk__in
=
ids
).
order_by
(
'index'
).
for_nested_serialization
()
serializer
=
serializers
.
PlaylistTrackSerializer
(
plts
,
many
=
True
)
data
=
{
'count'
:
len
(
plts
),
...
...
@@ -93,7 +96,7 @@ class PlaylistTrackViewSet(
viewsets
.
GenericViewSet
):
serializer_class
=
serializers
.
PlaylistTrackSerializer
queryset
=
(
models
.
PlaylistTrack
.
objects
.
all
())
queryset
=
(
models
.
PlaylistTrack
.
objects
.
all
()
.
for_nested_serialization
()
)
permission_classes
=
[
permissions
.
ConditionalAuthentication
,
permissions
.
OwnerPermission
,
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment