From ec8e1d13b5fee5e060faad742cbbca8978c0ad16 Mon Sep 17 00:00:00 2001
From: Kasper Seweryn <github@wvffle.net>
Date: Sat, 16 Apr 2022 13:39:54 +0200
Subject: [PATCH] Temporarily disable failing typescript rules
---
front/.eslintrc.js | 6 +++++-
front/package.json | 2 +-
front/src/components/admin/SignupFormBuilder.vue | 2 +-
front/src/views/Search.vue | 4 ++--
4 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/front/.eslintrc.js b/front/.eslintrc.js
index c4dbd635ea..6173dd0554 100644
--- a/front/.eslintrc.js
+++ b/front/.eslintrc.js
@@ -22,6 +22,10 @@ module.exports = {
],
rules: {
'vue/no-v-html': 'off', // TODO: tackle this properly
- 'vue/no-use-v-if-with-v-for': 'off'
+ 'vue/no-use-v-if-with-v-for': 'off',
+
+ // TODO: Enable typescript rules later
+ '@typescript-eslint/no-this-alias': 'off',
+ '@typescript-eslint/no-empty-function': 'off'
}
}
diff --git a/front/package.json b/front/package.json
index 075473c493..6337727a78 100644
--- a/front/package.json
+++ b/front/package.json
@@ -10,7 +10,7 @@
"build:deployment": "vite build --base /front/",
"serve": "vite preview",
"test:unit": "jest",
- "lint": "eslint --ext .js,.vue src",
+ "lint": "eslint --ext .ts,.js,.vue src",
"fix-fomantic-css": "scripts/fix-fomantic-css.sh",
"i18n-compile": "scripts/i18n-compile.sh",
"i18n-extract": "scripts/i18n-extract.sh",
diff --git a/front/src/components/admin/SignupFormBuilder.vue b/front/src/components/admin/SignupFormBuilder.vue
index 2ca887b99d..2f08dc0518 100644
--- a/front/src/components/admin/SignupFormBuilder.vue
+++ b/front/src/components/admin/SignupFormBuilder.vue
@@ -174,7 +174,7 @@ function arrayMove (arr, oldIndex, newIndex) {
}
arr.splice(newIndex, 0, arr.splice(oldIndex, 1)[0])
return arr
-};
+}
// v-model with objects is complex, cf
// https://simonkollross.de/posts/vuejs-using-v-model-with-objects-for-custom-components
diff --git a/front/src/views/Search.vue b/front/src/views/Search.vue
index 3ac5152d2e..1c5470bd1c 100644
--- a/front/src/views/Search.vue
+++ b/front/src/views/Search.vue
@@ -204,8 +204,8 @@ export default {
params.append('q', this.query)
params.append('page', this.page)
params.append('page_size', this.paginateBy)
- if (this.currentType.contentCategory !== undefined) { params.append('content_category', this.currentType.contentCategory) };
- if (this.currentType.includeChannels !== undefined) { params.append('include_channels', this.currentType.includeChannels) };
+ if (this.currentType.contentCategory !== undefined) { params.append('content_category', this.currentType.contentCategory) }
+ if (this.currentType.includeChannels !== undefined) { params.append('include_channels', this.currentType.includeChannels) }
return params
},
types () {
--
GitLab