Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
jovuit
funkwhale_OLD
Commits
78546232
Verified
Commit
78546232
authored
Jan 26, 2019
by
Eliot Berriot
Browse files
Fix #685: Disable makemigrations in production and misleading message when running migrate
parent
264aa20d
Changes
3
Hide whitespace changes
Inline
Side-by-side
api/funkwhale_api/common/management/commands/makemigrations.py
0 → 100644
View file @
78546232
import
os
from
django.core.management.base
import
CommandError
from
django.core.management.commands.makemigrations
import
Command
as
BaseCommand
class
Command
(
BaseCommand
):
def
handle
(
self
,
*
apps_label
,
**
options
):
"""
Running makemigrations in production can have desastrous consequences.
We ensure the command is disabled, unless a specific env var is provided.
"""
force
=
os
.
environ
.
get
(
"FORCE"
)
==
"1"
if
not
force
:
raise
CommandError
(
"Running makemigrations on your Funkwhale instance can have desastrous"
" consequences. This command is disabled, and should only be run in "
"development environments."
)
return
super
().
handle
(
*
apps_label
,
**
options
)
api/funkwhale_api/common/management/commands/migrate.py
0 → 100644
View file @
78546232
from
django.core.management.commands.migrate
import
Command
as
BaseCommand
def
patch_write
(
buffer
):
"""
Django is trying to help us when running migrate, by checking we don't have
model changes not included in migrations. Unfortunately, running makemigrations
on production instances create unwanted migrations and corrupt the database.
So we disabled the makemigrations command, and we're patching the
write method to ensure misleading messages are never shown to the user,
because https://github.com/django/django/blob/2.1.5/django/core/management/commands/migrate.py#L186
does not leave an easy way to disable them.
"""
unpatched
=
buffer
.
write
def
p
(
message
,
*
args
,
**
kwargs
):
if
"'manage.py makemigrations'"
in
message
or
"not yet reflected"
in
message
:
return
return
unpatched
(
message
,
*
args
,
**
kwargs
)
setattr
(
buffer
,
"write"
,
p
)
class
Command
(
BaseCommand
):
def
__init__
(
self
,
*
args
,
**
kwargs
):
super
().
__init__
(
*
args
,
**
kwargs
)
patch_write
(
self
.
stdout
)
changes/changelog.d/685.enhancement
0 → 100644
View file @
78546232
Disable makemigrations in production and misleading message when running migrate (#685)
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment