From e7e5ea1222adba56e9b7756067735e74ad82ac5c Mon Sep 17 00:00:00 2001
From: Adam Novak <interfect@gmail.com>
Date: Mon, 11 Jan 2021 21:55:14 -0800
Subject: [PATCH] Round transcoded lengths and note VBR Opus

---
 api/tests/music/test_utils.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/api/tests/music/test_utils.py b/api/tests/music/test_utils.py
index 8d409eaf8..c89e52f5d 100644
--- a/api/tests/music/test_utils.py
+++ b/api/tests/music/test_utils.py
@@ -29,7 +29,7 @@ def test_guess_mimetype_try_using_extension_if_fail(wrong, factories, mocker):
         ("sample.flac", {"bitrate": 1608000, "length": 0.001}),
         ("test.mp3", {"bitrate": 8000, "length": 267.70285714285717}),
         ("test.ogg", {"bitrate": 112000, "length": 1}),
-        ("test.opus", {"bitrate": 112000, "length": 1}),
+        ("test.opus", {"bitrate": 0, "length": 1}), # This Opus file lacks a bitrate
     ],
 )
 def test_get_audio_file_data(name, expected):
@@ -116,10 +116,10 @@ def test_get_dirs_and_files(path, expected, tmpdir):
 @pytest.mark.parametrize(
     "name, expected",
     [
-        ("sample.flac", {"bitrate": 1608000, "length": 0.001}),
-        ("test.mp3", {"bitrate": 8000, "length": 267.70285714285717}),
-        ("test.ogg", {"bitrate": 112000, "length": 1}),
-        ("test.opus", {"bitrate": 112000, "length": 1}),
+        ("sample.flac", {"bitrate": 1608000, "length": 0}),
+        ("test.mp3", {"bitrate": 16000, "length": 260}),
+        ("test.ogg", {"bitrate": 128000, "length": 1}),
+        ("test.opus", {"bitrate": 128000, "length": 1}),
     ],
 )
 def test_transcode_file(name, expected):
@@ -127,6 +127,6 @@ def test_transcode_file(name, expected):
     with tempfile.NamedTemporaryFile() as dest:
         utils.transcode_file(path, pathlib.Path(dest.name))
         with open(dest.name, "rb") as f:
-            result = utils.get_audio_file_data(f)
+            result = {k: round(v) for k, v in utils.get_audio_file_data(f).items()}
 
             assert result == expected
-- 
GitLab