funkwhale issueshttps://dev.funkwhale.audio/groups/funkwhale/-/issues2024-02-21T10:57:03Zhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2285Execute Tests in CI2024-02-21T10:57:03ZGeorg KrauseExecute Tests in CIAs soon as we start writing Rust code for the Desktop/Mobile App, we are also going to write tests. We should execute them in CI.
Acceptance criteria:
- [ ] XUnit test reporting
- [ ] Coverage reportingAs soon as we start writing Rust code for the Desktop/Mobile App, we are also going to write tests. We should execute them in CI.
Acceptance criteria:
- [ ] XUnit test reporting
- [ ] Coverage reporting1.5.0Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2273Update docs to get code from release assets2024-01-15T08:33:36ZGeorg KrauseUpdate docs to get code from release assetsThe following discussion from !2698 should be addressed:
- [ ] @georgkrause started a [discussion](https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2698#note_60825): (+5 comments)
> Currently the download URL for t...The following discussion from !2698 should be addressed:
- [ ] @georgkrause started a [discussion](https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2698#note_60825): (+5 comments)
> Currently the download URL for those assets would be:
>
> ```
> $git-ref=release-assets # might be develop, stable or a tag name
> $component=api|front
> $last-tag=1.4.0
> https://dev.funkwhale.audio/api/v4/projects/17/packages/generic/funkwhale/$git-ref/funkwhale-$component-$last-tag.zip
> ```
>
> @Sporiff I think for the docs we need to change this in order to make sure we can download with a fixed URL, right? Should we remove the version from the filename for this?
The correct URL now is `https://dev.funkwhale.audio/api/v4/projects/17/packages/generic/funkwhale/$git-ref/funkwhale-$component.zip`1.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2264Deprecate armv7 docker images2023-12-12T08:26:58ZGeorg KrauseDeprecate armv7 docker imagesA while back I started a discussion around the deprecation of armv7 docker images [in the forum](https://forum.funkwhale.audio/d/391-docker-armv7-support). The majority of the development group seemed to be in favor of the deprecation, s...A while back I started a discussion around the deprecation of armv7 docker images [in the forum](https://forum.funkwhale.audio/d/391-docker-armv7-support). The majority of the development group seemed to be in favor of the deprecation, so lets schedule this for %"1.5.0".
@funkwhale/communications This probably needs some cautious communications to avoid people getting highly upset, on the other hand the topic is quite complicated to explain to non-technical users. I'd appreciate some input on how to communicate this properly.1.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2261Deduplicate translation strings2023-12-09T13:19:16ZGeorg KrauseDeduplicate translation strings# Problem
At the moment, we have several duplicate translation strings in our locale files. This makes it tedious to translate our UI and makes it quite hard to manage the translations.
# Solution
We should make sure each and every tr...# Problem
At the moment, we have several duplicate translation strings in our locale files. This makes it tedious to translate our UI and makes it quite hard to manage the translations.
# Solution
We should make sure each and every translation string is only available once at a single key. This way translations would be way easier.1.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2131Replace duplicated script tags with defineOptions2023-12-12T08:35:06ZGeorg KrauseReplace duplicated script tags with defineOptionsWe can replace the duplicated `<script>` tags with `defineOptions`We can replace the duplicated `<script>` tags with `defineOptions`1.5.0Kasper Sewerynwvffle@funkwhale.audioKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2069Use release assets instead of artifacts to distibute the software2024-02-05T14:27:51ZjooolaUse release assets instead of artifacts to distibute the softwareI propose to change the current distribution method for released assets (currently using the build artifacts), to releases assets created from those artifacts.
It will put a clear separation between the CI and the distribution of the co...I propose to change the current distribution method for released assets (currently using the build artifacts), to releases assets created from those artifacts.
It will put a clear separation between the CI and the distribution of the code to the public. Dev installs still can download from the CI artifacts, as we are probably around to fix if we break it.
We will not have to be too careful about changing things in the CI, for example renaming one of the api/front build job would break the distribution pipeline. We need to have a proper release job, that pushes attaches those artifacts to a specific release.
This allows us to provide checksum files and maybe also sign the assets archive so people can verify the files after download.
We already create releases for our tags https://dev.funkwhale.audio/funkwhale/funkwhale/-/releases
We can now draft a clear and frozen policy on the release asset naming, and make sure we will not have to change it in the future.
In addition if we have a clear policy, we could also add the release/assets urls inside the releases.json files that is publicly available at https://docs.funkwhale.audio/releases.json.
Or releases.json becomes a proxy to the gitlab releases api.
I think this should happen for 1.3.0.
An example where we are having some issue with the current setup: https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2349#note_46070
Some docs: https://docs.gitlab.com/ee/user/project/releases/release_cicd_examples.html
cc @funkwhale/steering1.5.0Georg KrauseGeorg Krausehttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2065Start using make as task manager2023-11-16T10:33:27ZjooolaStart using make as task managerI propose to start using make as en entry point to run the different dev tasks.
The idea is to leverage the power of Make to define dependent tasks and use them to build more advanced task scenarios. Already run tasks will most of the t...I propose to start using make as en entry point to run the different dev tasks.
The idea is to leverage the power of Make to define dependent tasks and use them to build more advanced task scenarios. Already run tasks will most of the time by shipped unless we explicitly require them to always run (e.g. install the package `poetry install`).
This will be similar to the front/packages.json scripts section, but for the project and the api.
The Makefile itself already documents the available tasks for the developers, complex behavior should be commented and/or extracted into scripts
Here are a few tasks I hope to implement:
**Project**:
- dev: init a fully working dev setup with build+run+migration+seed using docker-compose #2071
- dev-federation: init a federation network with instances using docker-compose #2107
- version: bump the packages version to a new one (replace scripts/set-api-build-metadata.sh)
- docs: run a docs dev setup using docker-compose (docs and dev will be split to reduce complexity)
- clean: cleanup the project, but keep important files (git clean -xdf but keep .env, and other files)
- release: once the versions are bumped, the project is clean, we can run the task to release a new version, and let the user do the final "git push --follow-tags"
**API**:
- install: poetry install into api/.venv
- format: format all the code using black+isort (either via pre-commit, or directly with black and isort)
- lint: lint the api package using all available linters (pylint, mypy, maybe flake8)
- test: test the api package using pytest (running individual groups of tests should be done manually) (maybe splitting `test` into `unit` and `integration`)
- schema: generate the api schema
**Docs**:
- install: poetry install into docs/.venv
- build: build the docs, this would replace the existing scripts
It seems the docs ship a Makefile (from sphinx) but it isn't used.
Some other "common" tasks can be added, I might have missed some. We need to be careful and make sure the time invested in a makefile tasks is actually worth it. For example I can see the gitpod spec use the makefile, but scripting gitpod specific tasks in the makefile is probably not generic enough.1.5.0jooolaGeorg Krausejooolahttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2043Migrate pagination to VUI2023-11-16T10:34:30ZKasper Sewerynwvffle@funkwhale.audioMigrate pagination to VUIPart of #1919Part of #19191.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2042Migrate all cards to VUI2023-12-12T21:29:32ZKasper Sewerynwvffle@funkwhale.audioMigrate all cards to VUIPart of #1919Part of #19191.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2039Implement offline mode for the Funkwhale UI2023-11-16T10:27:36ZCiarán Ainsworthsporiff@funkwhale.audioImplement offline mode for the Funkwhale UIThe following discussion from !2330 should be addressed:
- [ ] @wvffle started a [discussion](https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2330#note_45078): (+3 comments)
> Well, you're most likely right when i...The following discussion from !2330 should be addressed:
- [ ] @wvffle started a [discussion](https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2330#note_45078): (+3 comments)
> Well, you're most likely right when it comes to what @JuniorJPDJ has expected.
> However the issue itself is wrong. [First commit before any of my changes](https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/0f4226e06fa3ce888df04666dd02c150d4380837/front/src/store/radios.js#L93-L104) also drops radio session when the candidate request fails.
>
> We could make funkwhale aware of it's online/offline state, inform user about it and handle all cases similar to what @JuniorJPDJ is expecting.1.5.0Ciarán Ainsworthsporiff@funkwhale.audioCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1809I-4 Automatic following of public libraries and channels2024-03-27T11:03:28ZpetitminionI-4 Automatic following of public libraries and channelsPart of #762
integrated into https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1806
Already done for channels :
On Channel creation -> creation of a public actor related to the channel -> creation of an activity to decl...Part of #762
integrated into https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/1806
Already done for channels :
On Channel creation -> creation of a public actor related to the channel -> creation of an activity to declare the channel creation to all known domains .
To do :
global fed is enable -> discovery -> follow :
- [x] Discover funkwhale domains in network.funkwhale https://network.funkwhale.audio/api/domains
- [x] Discover domain by asking to known domains unknown domains info.
- [x] Follow all domains we have in db when global fed is enable (new task, will allow to follow domain we discovered if follow failed during discovery process)
- [ ] add to the doc the fact that channel will federate in any cases but libraries will only federate if global federation is enabled.1.5.0Ciarán Ainsworthsporiff@funkwhale.audiopetitminionCiarán Ainsworthsporiff@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1694Rename components & eslint-plugin-vue v8 update2023-12-14T08:34:53ZGeorg KrauseRename components & eslint-plugin-vue v8 updateWhen upgrading to eslint 8 we get the following issues:
```
/builds/funkwhale/funkwhale/front/src/components/About.vue
1:1 error Component name "About" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/fu...When upgrading to eslint 8 we get the following issues:
```
/builds/funkwhale/funkwhale/front/src/components/About.vue
1:1 error Component name "About" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/Footer.vue
1:1 error Component name "Footer" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/Home.vue
1:1 error Component name "Home" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/Logo.vue
1:1 error Component name "Logo" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/Pagination.vue
1:1 error Component name "Pagination" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/Queue.vue
1:1 error Component name "Queue" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/Sidebar.vue
485:9 error Component name "Sidebar" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/Player.vue
1:1 error Component name "Player" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/Search.vue
1:1 error Component name "Search" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/album/Card.vue
1:1 error Component name "Card" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/album/Widget.vue
1:1 error Component name "Widget" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/artist/Card.vue
1:1 error Component name "Card" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/artist/Widget.vue
1:1 error Component name "Widget" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/podcast/Modal.vue
1:1 error Component name "Modal" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/podcast/Row.vue
1:1 error Component name "Row" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/podcast/Table.vue
1:1 error Component name "Table" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/track/Modal.vue
1:1 error Component name "Modal" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/track/Row.vue
1:1 error Component name "Row" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/track/Table.vue
1:1 error Component name "Table" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/audio/track/Widget.vue
1:1 error Component name "Widget" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/auth/Authorize.vue
1:1 error Component name "Authorize" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/auth/Logout.vue
1:1 error Component name "Logout" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/auth/Plugin.vue
1:1 error Component name "Plugin" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/auth/Settings.vue
1:1 error Component name "Settings" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/common/Duration.vue
1:1 error Component name "Duration" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/common/Message.vue
1:1 error Component name "Message" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/common/Tooltip.vue
1:1 error Component name "Tooltip" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/common/UserModal.vue
158:11 error Unexpected useless attribute on `<template>` vue/no-useless-template-attributes
159:11 error Unexpected useless attribute on `<template>` vue/no-useless-template-attributes
/builds/funkwhale/funkwhale/front/src/components/common/Username.vue
1:1 error Component name "Username" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/favorites/List.vue
1:1 error Component name "List" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/globals.js
5:15 error Component name "Username" should always be multi-word vue/multi-word-component-names
9:15 error Component name "Duration" should always be multi-word vue/multi-word-component-names
11:15 error Component name "Message" should always be multi-word vue/multi-word-component-names
14:15 error Component name "Tooltip" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/Albums.vue
1:1 error Component name "Albums" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/Artists.vue
1:1 error Component name "Artists" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/Home.vue
84:9 error Component name "Library" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/Library.vue
1:1 error Component name "Library" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/Podcasts.vue
1:1 error Component name "Podcasts" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/Radios.vue
1:1 error Component name "Radios" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/radios/Builder.vue
1:1 error Component name "Builder" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/library/radios/Filter.vue
1:1 error Component name "Filter" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/mixins/Ordering.vue
1:1 error Component name "Ordering" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/mixins/Pagination.vue
1:1 error Component name "Pagination" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/mixins/Report.vue
1:1 error Component name "Report" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/mixins/Themes.vue
1:1 error Component name "Themes" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/mixins/Translations.vue
1:1 error Component name "Translations" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/notifications/NotificationRow.vue
19:9 error Unexpected useless directive on `<template>` vue/no-useless-template-attributes
/builds/funkwhale/funkwhale/front/src/components/playlists/Card.vue
1:1 error Component name "Card" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/playlists/Editor.vue
1:1 error Component name "Editor" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/playlists/Form.vue
1:1 error Component name "Form" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/playlists/Widget.vue
1:1 error Component name "Widget" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/radios/Button.vue
1:1 error Component name "Button" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/radios/Card.vue
1:1 error Component name "Card" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/semantic/Modal.vue
1:1 error Component name "Modal" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/components/tags/List.vue
1:1 error Component name "List" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/Notifications.vue
1:1 error Component name "Notifications" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/Search.vue
1:1 error Component name "Search" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/admin/Settings.vue
1:1 error Component name "Settings" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/admin/library/Base.vue
1:1 error Component name "Base" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/admin/moderation/Base.vue
1:1 error Component name "Base" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/admin/users/Base.vue
1:1 error Component name "Base" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/auth/Callback.vue
1:1 error Component name "Callback" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/auth/Login.vue
1:1 error Component name "Login" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/auth/Plugins.vue
1:1 error Component name "Plugins" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/auth/Signup.vue
1:1 error Component name "Signup" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/Base.vue
1:1 error Component name "Base" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/Home.vue
1:1 error Component name "Home" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/libraries/Card.vue
1:1 error Component name "Card" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/libraries/Files.vue
1:1 error Component name "Files" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/libraries/Form.vue
1:1 error Component name "Form" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/libraries/Home.vue
1:1 error Component name "Home" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/libraries/Quota.vue
1:1 error Component name "Quota" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/remote/Card.vue
1:1 error Component name "Card" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/content/remote/Home.vue
1:1 error Component name "Home" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/library/Edit.vue
1:1 error Component name "Edit" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/library/Upload.vue
1:1 error Component name "Upload" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/playlists/Detail.vue
1:1 error Component name "Detail" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/playlists/List.vue
1:1 error Component name "List" should always be multi-word vue/multi-word-component-names
/builds/funkwhale/funkwhale/front/src/views/radios/Detail.vue
1:1 error Component name "Detail" should always be multi-word vue/multi-word-component-names
```
More information: https://eslint.vuejs.org/rules/multi-word-component-names.html1.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1643Radio description not shown in radio details page2023-11-16T10:35:07ZJuniorJPDJRadio description not shown in radio details pageRadio details:
![Screenshot_20211212_114928](/uploads/3671230744e058d0030a203166eb83ae/Screenshot_20211212_114928.png)
Builder:
![Screenshot_20211212_114823](/uploads/b3fb5343dff7b374eb769f123cef3e67/Screenshot_20211212_114823.png)
R...Radio details:
![Screenshot_20211212_114928](/uploads/3671230744e058d0030a203166eb83ae/Screenshot_20211212_114928.png)
Builder:
![Screenshot_20211212_114823](/uploads/b3fb5343dff7b374eb769f123cef3e67/Screenshot_20211212_114823.png)
Radios list:
![Screenshot_20211212_114850](/uploads/788d28ce040fcb40ab38876551c01229/Screenshot_20211212_114850.png)
Funkwhale version: 1.2.0-rc1+git.8325184d (develop)1.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1618Replace Fomantic2024-01-19T12:35:02ZGeorg KrauseReplace FomanticOur current interface is built using [Fomantic UI](https://fomantic-ui.com/).
While working with it, it has some issues I'd like to address:
* It bundles jQuery, so we have basically two huge JS libs.
* Its heavily using JS while we on...Our current interface is built using [Fomantic UI](https://fomantic-ui.com/).
While working with it, it has some issues I'd like to address:
* It bundles jQuery, so we have basically two huge JS libs.
* Its heavily using JS while we only use it for styling.
Further we have some software design problems in relation to fomantic ui (not their fault, though!). The issue is that we use fomantic everywhere in the code and its not encapsulated. So breaking changes on their site require us to change a lot of references. I think we can improve here.
My vision is to exchange fomantic with a CSS-Only Framework like bulma.io or similiar (I'd like to hear your suggestions!).
The path to work on this could look something like this:
* Improve the encapsulation. All Fomantic/jQuery references should be put into some basic components.
* Reimplement those basic components with a CSS Framework.1.5.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1469III-5 Quality filter for content2024-02-06T13:04:46ZMathieu JourdanIII-5 Quality filter for contentAs part of #1235, require a minimal quality for content on first page:
- [ ] show only content with album arts / pictures and filled in metadata on first page
- [ ] show only content with audio bitrate higher than mp3@128kbps
- forum :...As part of #1235, require a minimal quality for content on first page:
- [ ] show only content with album arts / pictures and filled in metadata on first page
- [ ] show only content with audio bitrate higher than mp3@128kbps
- forum : https://forum.funkwhale.audio/d/292-quality-filter-proposal/3
- spec : is [here](https://docs.funkwhale.audio/develop/specs/quality-filter/index.html)1.5.0petitminionpetitminionhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1468Homepage improvements2023-11-16T10:33:52ZMathieu JourdanHomepage improvementsAs part of #1235:
- [ ] fix existing cards #973#note_19820
- [ ] make grid responsive
- [ ] implement new homepage layout (excluding extra features)
[Link to mockups](https://design.funkwhale.audio/#/view/e3a187f0-0f5e-11ed-adb9-fff9e8...As part of #1235:
- [ ] fix existing cards #973#note_19820
- [ ] make grid responsive
- [ ] implement new homepage layout (excluding extra features)
[Link to mockups](https://design.funkwhale.audio/#/view/e3a187f0-0f5e-11ed-adb9-fff9e854a67c?page-id=04743db0-0f5f-11ed-adb9-fff9e854a67c§ion=interactions&index=0&share-id=e34466e0-5ad8-11ed-b91a-c19cdb5a453b)
Edit: replace inkscape mockup with link to penpot
This is part if Funding III-61.5.0Kasper Sewerynwvffle@funkwhale.audioKasper Sewerynwvffle@funkwhale.audiohttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/653Enable starting embedded player at a specific position in track2023-12-11T15:13:34ZAgateEnable starting embedded player at a specific position in trackcf https://dev.funkwhale.audio/funkwhale/funkwhale/issues/578#note_7509
Something similar to PeerTube / YouTube: `<iframe src="https://pe.ertu.be/videos/embed/c98581dd-8848-490c-a3e0-f883b085b8e9?start=6m32s"></iframe>
`
cc @kristinitacf https://dev.funkwhale.audio/funkwhale/funkwhale/issues/578#note_7509
Something similar to PeerTube / YouTube: `<iframe src="https://pe.ertu.be/videos/embed/c98581dd-8848-490c-a3e0-f883b085b8e9?start=6m32s"></iframe>
`
cc @kristinita1.5.0Mathieu JourdanMathieu Jourdanhttps://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2282Drop Python 3.82024-02-05T14:12:00ZGeorg KrauseDrop Python 3.8It wont be supported by the data of release of %"1.6.0"It wont be supported by the data of release of %"1.6.0"1.6.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2263Stop building docker images for amv72023-12-12T08:27:49ZGeorg KrauseStop building docker images for amv7<!--
Hello and welcome to our issue tracker! We appreciate you taking the time to help us make Funkwhale even better :smile:
Before you begin, here are some helpful tips for submitting an issue:
* If you need help setting up or using ...<!--
Hello and welcome to our issue tracker! We appreciate you taking the time to help us make Funkwhale even better :smile:
Before you begin, here are some helpful tips for submitting an issue:
* If you need help setting up or using Funkwhale, try asking in our
[forum's support board](https://forum.funkwhale.audio/support) or our [support
chat room](https://riot.im/app/#/room/#funkwhale-support:tchncs.de).
* If you think you've found a bug but aren't sure, you can ask in one of the above channels
first. Once you're confident it's a bug, go ahead and create an issue for us to investigate.
Select the **Bug** template in the **Description** dropdown menu. This template contains
helpful tips for creating your report.
* For smaller additions and enhancements, please file a feature request.
Select the **Feature Request** template in the **Description** dropdown
menu. This template contains helpful tips for creating your request.
* If you have ideas for new features or use cases, consider opening a thread in our
[forum](https://forum.funkwhale.audio/t/development). This enables us to
discuss the feature, its use cases, and the development effort it requires.
We always like hearing ideas from our community. If you're still not sure, click
the **Create issue** button and we'll work with you to sort out the issue.
Happy listening! :whale:
-->1.6.0https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2281Remove deprecated funkwhaleVersion from subsonic2024-02-02T08:50:01ZGeorg KrauseRemove deprecated funkwhaleVersion from subsonicIn !2695 we deprecated the `funkwhaleVersion` subsonic API field in favor of the opensubsonic field `serverVersion`. We need to remove the deprecated API fieldIn !2695 we deprecated the `funkwhaleVersion` subsonic API field in favor of the opensubsonic field `serverVersion`. We need to remove the deprecated API field1.7.0