mopidy issueshttps://dev.funkwhale.audio/funkwhale/mopidy/-/issues2022-01-18T04:03:32Zhttps://dev.funkwhale.audio/funkwhale/mopidy/-/issues/20Getting playlists from funkwhale2022-01-18T04:03:32ZToke Høiland-JørgensenGetting playlists from funkwhaleWould it be possible to also show playlists from funkwhale? This was mentioned in #15, but looks like it was dropped from there?Would it be possible to also show playlists from funkwhale? This was mentioned in #15, but looks like it was dropped from there?https://dev.funkwhale.audio/funkwhale/mopidy/-/issues/19Browsing albums in Iris doesn't work2022-02-14T13:36:10ZErinBrowsing albums in Iris doesn't workBrowsing to a funkwhale album in Iris displays a page like this:
<details><summary>Click to expand</summary>
![image](/uploads/41802fa58b776a6be13509eca1b2a45f/image.png)
</details>
[Mopidy's documentation for `library.browse`](https:/...Browsing to a funkwhale album in Iris displays a page like this:
<details><summary>Click to expand</summary>
![image](/uploads/41802fa58b776a6be13509eca1b2a45f/image.png)
</details>
[Mopidy's documentation for `library.browse`](https://docs.mopidy.com/en/latest/api/core/#mopidy.core.LibraryController.browse) indicates that browsing should only return directory and/or track refs. I've confirmed that other extensions such as Mopidy-Local ~~and Mopidy-Spotify~~ do this. The current behaviour here is to return album refs when browsing albums, artist refs when browsing artists, etc. This appears to mostly work, but I've run into some flakiness when using Mopidy-Iris to browse my funkwhale library and albums won't display tracks properly unless I open them via search results. **(NOTE: [see below](https://dev.funkwhale.audio/funkwhale/mopidy/-/issues/19#note_24622))**
<details><summary>When I view <code>funkwhale:directory:albums:by-name</code>, this happens</summary>
<pre>
ERROR 2021-08-15 20:17:57,965 [45168:Core-7] mopidy.core.library
FunkwhaleBackend backend returned bad data: Expected a list of Track, not [Ref(name='...', type='album', uri='funkwhale:directory:albums:by-name:5'), Ref(name='...', type='album', uri='funkwhale:directory:albums:by-name:6'), ...]
</pre>
</details>
Also I hope I'm not causing too many notifications here. I haven't really contributed to any public projects before so I'm trying to keep things small. I've been slowly getting this extension to work better with Iris locally. I'd like to try to share my work as I get it cleaned up, but I'm just tackling problems as I find them so I'm not sure what the best way to keep everything organized is.https://dev.funkwhale.audio/funkwhale/mopidy/-/issues/18library.get_images only works for tracks, not albums or artists2021-08-14T04:03:18ZErinlibrary.get_images only works for tracks, not albums or artists`library.get_images` returns images based on the track matching the requested id, even if the URI refers to a different type of resource. This makes viewing albums and artists in a client that supports images for them pretty confusing, w...`library.get_images` returns images based on the track matching the requested id, even if the URI refers to a different type of resource. This makes viewing albums and artists in a client that supports images for them pretty confusing, with seemingly random thumbnails.
<details><summary>Mopidy logs showing said behaviour</summary>
<pre>
DEBUG:mopidy.http.handlers:Received WebSocket message from 10.0.1.28: '{"method":"core.library.get_images","params":{"uris":["funkwhale:directory:albums:by-name:5"]},"jsonrpc":"2.0","id":14}'
DEBUG:mopidy_funkwhale.library:Handling get images: ['funkwhale:directory:albums:by-name:5']
DEBUG:requests_oauthlib.oauth2_session: ...
DEBUG:urllib3.connectionpool:https://funkwhale:443 "GET /api/v1/tracks/5/ HTTP/1.1" 200 2782
DEBUG:mopidy.http.handlers:Sent WebSocket message to 10.0.1.28: '{"jsonrpc": "2.0", "id": 14, "result": {"funkwhale:directory:albums:by-name:5": [{"__model__": "Image", "uri": "https://funkwhale/media/attachments/8d/6e/4d/attachment_cover-86d86086-1ddb-4092-be19-5e00974f8ef1.png"}, {"__model__": "Image", "uri": "https://funkwhale/media/__sized__/attachments/8d/6e/4d/attachment_cover-86d86086-1ddb-4092-be19-5e00974f8ef1-crop-c0-5__0-5-200x200.png", "width": 200, "height": 200}, {"__model__": "Image", "uri": "https://funkwhale/media/__sized__/attachments/8d/6e/4d/attachment_cover-86d86086-1ddb-4092-be19-5e00974f8ef1-crop-c0-5__0-5-600x600.png", "width": 600, "height": 600}]}}'
</pre>
</details>https://dev.funkwhale.audio/funkwhale/mopidy/-/issues/14Improve setup guide in readme2021-03-10T19:49:56ZGeorg KrauseImprove setup guide in readmeThere are different ways to setup mopidy itself. We should make clear which steps are required to setup the plugin in a specific setup.There are different ways to setup mopidy itself. We should make clear which steps are required to setup the plugin in a specific setup.backloghttps://dev.funkwhale.audio/funkwhale/mopidy/-/issues/11Implement funkwhale scrobbling2021-06-02T04:03:57ZGeorg KrauseImplement funkwhale scrobblingFunkwhale provide API endpoints which allow the player to report which song was played. We should bring this to the mopidy-plugin.
I want to work on this, but I do have some questions.
1. I am not sure, when to report the song was play...Funkwhale provide API endpoints which allow the player to report which song was played. We should bring this to the mopidy-plugin.
I want to work on this, but I do have some questions.
1. I am not sure, when to report the song was played. After playback starts? Or after the hole song is played? Or simply when it stops?
1. It seems we need to inherit from `mopidy.core.CoreListener`. Is it save to do this in the `FunkwhaleBackend` or should we implement an additional `FunkwhaleFrontend` for this?
There is already an scrobbler for last fm: https://github.com/mopidy/mopidy-scrobbler/blob/master/mopidy_scrobbler/frontend.py
Otter uses `/api/v1/history/listenings/` for this, which does not seem to be documented somehow.backlog